Skip to content

[CNV-52364] IBM Z remove tp and update compatibility list #93379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

SNiemann15
Copy link
Contributor

@SNiemann15 SNiemann15 commented May 14, 2025

Version(s): 4.19+

Issue:
https://issues.redhat.com/browse/CNV-52364

Link to docs preview: (openshift-enterprise)
https://93379--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/install/preparing-cluster-for-virt.html

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 14, 2025
@SNiemann15 SNiemann15 force-pushed the ocpvirt_ibmz_compatibility branch from a1b4149 to fb85de4 Compare May 15, 2025 09:40
@SNiemann15 SNiemann15 changed the title RHOCPV IBM Z remove tp and update compatibility list [CNV-52364] IBM Z remove tp and update compatibility list May 15, 2025
@SNiemann15 SNiemann15 force-pushed the ocpvirt_ibmz_compatibility branch from fb85de4 to a28fd96 Compare May 15, 2025 10:12
@nbziouec
Copy link

/lgtm

Copy link

openshift-ci bot commented May 15, 2025

@nbziouec: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@SNiemann15
Copy link
Contributor Author

/label peer-review-needed

fyi: @ousleyp

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 15, 2025
@SNiemann15 SNiemann15 force-pushed the ocpvirt_ibmz_compatibility branch from a28fd96 to e9f965f Compare May 15, 2025 13:59
@@ -249,6 +234,8 @@ You can configure one of the following high-availability (HA) options for your c
[NOTE]
====
In {product-title} clusters installed using installer-provisioned infrastructure and with a properly configured `MachineHealthCheck` resource, if a node fails the machine health check and becomes unavailable to the cluster, it is recycled. What happens next with VMs that ran on the failed node depends on a series of conditions. See xref:../../virt/nodes/virt-node-maintenance.adoc#run-strategies[Run strategies] for more detailed information about the potential outcomes and how run strategies affect those outcomes.

Currently, IPI is not supported on {ibm-z-name}.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] RedHat.TermsErrors: Use 'installer-provisioned infrastructure' rather than 'IPI'. For more information, see RedHat.TermsErrors.

@rh-tokeefe
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 15, 2025
@rh-tokeefe
Copy link
Contributor

@SNiemann15 just a friendly reminder to squash the PR before sending it for merge review. Otherwise LGTM!

@rh-tokeefe
Copy link
Contributor

/remove-label peer-review-needed

@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label May 15, 2025
@rh-tokeefe
Copy link
Contributor

/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 15, 2025
@rh-tokeefe
Copy link
Contributor

/label peer-review-done

@openshift-ci openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label May 15, 2025
@SNiemann15 SNiemann15 force-pushed the ocpvirt_ibmz_compatibility branch from e9f965f to 9654675 Compare May 16, 2025 05:59
Copy link

openshift-ci bot commented May 16, 2025

@SNiemann15: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@SNiemann15
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 16, 2025
@nbziouec
Copy link

/lgtm

Copy link

openshift-ci bot commented May 16, 2025

@nbziouec: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lpettyjo lpettyjo added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.19 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels May 16, 2025
@lpettyjo lpettyjo added this to the Planned for 4.19 GA milestone May 16, 2025
@lpettyjo lpettyjo merged commit 99afad7 into openshift:main May 16, 2025
2 checks passed
@lpettyjo
Copy link
Contributor

/cherrypick enterprise-4.19

@openshift-cherrypick-robot

@lpettyjo: new pull request created: #93490

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.19 merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants