Skip to content

OSSM-9339 Document Istio-CNI Update Process #93404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jab-rh merged 1 commit into from
Jun 12, 2025
Merged

OSSM-9339 Document Istio-CNI Update Process #93404

jab-rh merged 1 commit into from
Jun 12, 2025

Conversation

@shreyasiddhartha
Copy link
Contributor

@shreyasiddhartha shreyasiddhartha commented May 15, 2025 •
edited
Loading

Change type: Doc update; OSSM document Istio-CNI Update Process

Doc JIRA: https://issues.redhat.com/browse/OSSM-9339

Fix Version: service-mesh-docs-main and service-mesh-docs-3.0

NOTE TO THE SME and QE: This PR only covers the following sections from the docs:

  • About Istio CNI update process
  • Updating the Istio CNI resource version

The main story is: OSSM-8218

Doc Preview: https://93404--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/update/ossm-updating-openshift-service-mesh.html#ossm-about-istio-cni-update-process_ossm-updating-openshift-service-mesh

SME Review/QE Review: @MaxBab @pbajjuri20
Peer Review: @ShaunaDiaz

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 15, 2025
@shreyasiddhartha
Copy link
Contributor Author

shreyasiddhartha commented May 15, 2025

/label service-mesh

@openshift-ci openshift-ci bot added the service-mesh Label for all Service Mesh PRs label May 15, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 15, 2025 •
edited
Loading

🤖 Thu Jun 12 13:09:35 - Prow CI generated the docs preview:

https://93404--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/update/ossm-updating-openshift-service-mesh.html

@shreyasiddhartha shreyasiddhartha force-pushed the OSSM-9339 branch 2 times, most recently from 444b755 to 1e78135 Compare June 11, 2025 09:30
@shreyasiddhartha
Copy link
Contributor Author

shreyasiddhartha commented Jun 11, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 11, 2025
@ShaunaDiaz ShaunaDiaz added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 11, 2025
ShaunaDiaz
ShaunaDiaz reviewed Jun 11, 2025
View reviewed changes
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nits, looks great

@ShaunaDiaz ShaunaDiaz added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 11, 2025
@shreyasiddhartha
Copy link
Contributor Author

shreyasiddhartha commented Jun 12, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 12, 2025
@ShaunaDiaz ShaunaDiaz added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jun 12, 2025
ShaunaDiaz
ShaunaDiaz reviewed Jun 12, 2025
View reviewed changes
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment; procedure is missing an intro sentence

@ShaunaDiaz ShaunaDiaz removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jun 12, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jun 12, 2025

@shreyasiddhartha: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shreyasiddhartha
Copy link
Contributor Author

shreyasiddhartha commented Jun 12, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 12, 2025
@jab-rh jab-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jun 12, 2025
@jab-rh jab-rh merged commit 329fa95 into openshift:service-mesh-docs-main Jun 12, 2025
2 checks passed
@jab-rh
Copy link
Contributor

jab-rh commented Jun 12, 2025

/cherry-pick service-mesh-docs-3.0

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 12, 2025

@jab-rh: new pull request created: #94684

In response to this:

/cherry-pick service-mesh-docs-3.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 12, 2025
Merged
@jab-rh jab-rh removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShaunaDiaz ShaunaDiaz ShaunaDiaz left review comments

+2 more reviewers

@MaxBab MaxBab MaxBab approved these changes

@pbajjuri20 pbajjuri20 pbajjuri20 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

peer-review-done Signifies that the peer review team has reviewed this PR service-mesh Label for all Service Mesh PRs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@shreyasiddhartha @ocpdocs-previewbot @jab-rh @openshift-cherrypick-robot @MaxBab @pbajjuri20 @ShaunaDiaz