Skip to content

OSDOCS-14094 Pre-publish feedback for Prepare your environment #93569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2025
Merged

OSDOCS-14094 Pre-publish feedback for Prepare your environment #93569

merged 1 commit into from
Jun 9, 2025
+229 −837

Conversation

laubai
Copy link
Contributor

@laubai laubai commented May 20, 2025 •
edited
Loading

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 20, 2025
@laubai
Copy link
Contributor Author

laubai commented May 20, 2025

/test all

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 20, 2025 •
edited
Loading

🤖 Mon Jun 09 10:32:54 - Prow CI generated the docs preview:
https://93569--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@laubai laubai force-pushed the osdocs-14094-feedback-hcp-prepare-your-environment branch 4 times, most recently from 8c95ab9 to ffe3fa4 Compare May 21, 2025 11:29
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed May 21, 2025
View reviewed changes
@laubai laubai force-pushed the osdocs-14094-feedback-hcp-prepare-your-environment branch from ffe3fa4 to 67a30d5 Compare May 22, 2025 06:40
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed May 22, 2025
View reviewed changes
@laubai laubai force-pushed the osdocs-14094-feedback-hcp-prepare-your-environment branch 3 times, most recently from 8b97839 to 1a0e6b3 Compare May 27, 2025 04:41
@laubai
Copy link
Contributor Author

laubai commented May 27, 2025

/test all

@laubai
Copy link
Contributor Author

laubai commented May 29, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 29, 2025
@snarayan-redhat snarayan-redhat added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 29, 2025
EricPonvelle
EricPonvelle reviewed May 29, 2025
View reviewed changes
Copy link
Contributor

@EricPonvelle EricPonvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagged a bunch of small things

@laubai laubai force-pushed the osdocs-14094-feedback-hcp-prepare-your-environment branch from 1a0e6b3 to bc03868 Compare June 2, 2025 10:50
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 2, 2025
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jun 2, 2025
View reviewed changes
@laubai laubai force-pushed the osdocs-14094-feedback-hcp-prepare-your-environment branch from bc03868 to 3052536 Compare June 2, 2025 11:03
@snarayan-redhat snarayan-redhat added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 2, 2025
EricPonvelle
EricPonvelle reviewed Jun 2, 2025
View reviewed changes
Copy link
Contributor

@EricPonvelle EricPonvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2025
@laubai
Copy link
Contributor Author

laubai commented Jun 3, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 3, 2025
@mburke5678 mburke5678 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jun 3, 2025
mburke5678
mburke5678 reviewed Jun 3, 2025
View reviewed changes
mburke5678
mburke5678 reviewed Jun 3, 2025
View reviewed changes
mburke5678
mburke5678 reviewed Jun 3, 2025
View reviewed changes
mburke5678
mburke5678 reviewed Jun 3, 2025
View reviewed changes
mburke5678
mburke5678 reviewed Jun 3, 2025
View reviewed changes
mburke5678
mburke5678 reviewed Jun 3, 2025
View reviewed changes
mburke5678
mburke5678 reviewed Jun 3, 2025
View reviewed changes
mburke5678
mburke5678 reviewed Jun 3, 2025
View reviewed changes
@mburke5678
Copy link
Contributor

@laubai I found some issues, none of which is a show-stopper, I think. However, I am not clear on what the changes are in the previews. Can you help identify what is different in the previews?
I noticed this issue with numbering in this module, but I don't think you touched it.

@laubai laubai force-pushed the osdocs-14094-feedback-hcp-prepare-your-environment branch from 3052536 to 7520ad5 Compare June 9, 2025 10:11
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 9, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 9, 2025
@laubai
Copy link
Contributor Author

laubai commented Jun 9, 2025

@laubai I found some issues, none of which is a show-stopper, I think. However, I am not clear on what the changes are in the previews. Can you help identify what is different in the previews? I noticed this issue with numbering in this module, but I don't think you touched it.

Thanks for the detailed review @mburke5678 - a little more context below:

This PR applies some extra stakeholder feedback to the "Prepare your environment" ROSA doc that was split into HCP and Classic versions in OSDOCS-11789. The main changes requested are in the following sections (as well as some other sections that contain similar info in a more checklist-y style):

lmk if you have any other questions :)

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 9, 2025

@laubai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mburke5678 mburke5678 merged commit 0374ce9 into openshift:main Jun 9, 2025
2 checks passed
@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.18

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.19

@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #94470

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 9, 2025
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #94471

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricPonvelle EricPonvelle EricPonvelle left review comments

@mburke5678 mburke5678 mburke5678 left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Assignees

@EricPonvelle EricPonvelle

Labels
branch/enterprise-4.18 branch/enterprise-4.19 merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@laubai @ocpdocs-previewbot @mburke5678 @openshift-cherrypick-robot @EricPonvelle @ocpdocs-vale-bot @snarayan-redhat