Skip to content

TELCODOCS-2342: Fixes for hub cluster 4.18 and later #94446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

TELCODOCS-2342: Fixes for hub cluster 4.18 and later #94446

merged 1 commit into from
Jun 10, 2025
+12 −15

Conversation

rohennes
Copy link
Contributor

@rohennes rohennes commented Jun 9, 2025 •
edited
Loading

TELCODOCS-2342: Fixes for hub cluster 4.18 and later

Version(s):
4.18+

Issue:
https://issues.redhat.com/browse/TELCODOCS-2342

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 9, 2025 •
edited by openshift-ci bot
Loading

@rohennes: This pull request references TELCODOCS-2342 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

TELCODOCS-2342: Fixes for hub cluster 4.18 and later

Version(s):
4.18+

Issue:
https://issues.redhat.com/browse/TELCODOCS-2342

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 9, 2025 •
edited by openshift-ci bot
Loading

@rohennes: This pull request references TELCODOCS-2342 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

TELCODOCS-2342: Fixes for hub cluster 4.18 and later

Version(s):
4.18+

Issue:
https://issues.redhat.com/browse/TELCODOCS-2342

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 9, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 9, 2025 •
edited
Loading

🤖 Mon Jun 09 18:44:50 - Prow CI generated the docs preview:

https://94446--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/telco-hub-rds.html

@rohennes rohennes force-pushed the TELCODOCS-2342-hub-fixes branch 2 times, most recently from b3a8af5 to 39dd614 Compare June 9, 2025 18:11
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 9, 2025
@rohennes rohennes force-pushed the TELCODOCS-2342-hub-fixes branch from 39dd614 to 25879e5 Compare June 9, 2025 18:17
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 9, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 9, 2025

@rohennes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

imiller0
imiller0 reviewed Jun 9, 2025
View reviewed changes
Copy link

@imiller0 imiller0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2025
@agurenko
Copy link

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 10, 2025

@agurenko: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 10, 2025 •
edited by openshift-ci bot
Loading

@rohennes: This pull request references TELCODOCS-2342 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

TELCODOCS-2342: Fixes for hub cluster 4.18 and later

Version(s):
4.18+

Issue:
https://issues.redhat.com/browse/TELCODOCS-2342

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rohennes
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 10, 2025
@GroceryBoyJr
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed
/assign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 10, 2025
GroceryBoyJr
GroceryBoyJr reviewed Jun 10, 2025
View reviewed changes
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GroceryBoyJr
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-in-progress
/unassign GroceryBoyJr

@openshift-ci openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label Jun 10, 2025
@openshift-ci openshift-ci bot removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jun 10, 2025
@rohennes
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 10, 2025
@jeana-redhat jeana-redhat added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jun 10, 2025
jeana-redhat
jeana-redhat approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

/remove-label merge-review-in-progress
/remove-label merge-review-needed

@jeana-redhat jeana-redhat added this to the Continuous Release milestone Jun 10, 2025
@jeana-redhat jeana-redhat merged commit adfa2d1 into openshift:main Jun 10, 2025
2 checks passed
@jeana-redhat
Copy link
Contributor

/cherrypick enterprise-4.19

@jeana-redhat
Copy link
Contributor

/cherrypick enterprise-4.18

@openshift-ci openshift-ci bot removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Jun 10, 2025
@openshift-cherrypick-robot
Copy link

@jeana-redhat: #94446 failed to apply on top of branch "enterprise-4.18":

Applying: TELCODOCS-2342: Fixes for hub cluster 4.18 and later
Using index info to reconstruct a base tree...
M	scalability_and_performance/telco-hub-rds.adoc
Falling back to patching base and 3-way merge...
Auto-merging scalability_and_performance/telco-hub-rds.adoc
CONFLICT (content): Merge conflict in scalability_and_performance/telco-hub-rds.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 TELCODOCS-2342: Fixes for hub cluster 4.18 and later

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@jeana-redhat: new pull request created: #94534

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 10, 2025
Merged
@jeana-redhat
Copy link
Contributor

@rohennes sorry 4.18 needs a helping hand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imiller0 imiller0 imiller0 left review comments

@GroceryBoyJr GroceryBoyJr GroceryBoyJr left review comments

@jeana-redhat jeana-redhat jeana-redhat approved these changes

Assignees

@imiller0 imiller0

Labels
branch/enterprise-4.18 branch/enterprise-4.19 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
8 participants
@rohennes @openshift-ci-robot @ocpdocs-previewbot @agurenko @GroceryBoyJr @jeana-redhat @openshift-cherrypick-robot @imiller0