-
Notifications
You must be signed in to change notification settings - Fork 1.8k
TELCODOCS-2284: Updates for 4.19 hub cluster with GA support #94468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@rohennes: This pull request references TELCODOCS-2284 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.20." or "openshift-4.20.", but it targets "openshift-4.19" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
@rohennes: This pull request references TELCODOCS-2284 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.20." or "openshift-4.20.", but it targets "openshift-4.19" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Tue Jun 10 15:31:51 - Prow CI generated the docs preview: |
@rohennes: This pull request references TELCODOCS-2284 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.20." or "openshift-4.20.", but it targets "openshift-4.19" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@@ -19,8 +19,6 @@ To maintain multiple per-version policies simultaneously, use Git to manage the | |||
|
|||
|
|||
Limits and requirements:: | |||
* 300 single node `SiteConfig` CRs can be synchronized for each ArgoCD application. | |||
You can use multiple applications to achieve the maximum number of clusters supported by a single hub cluster. | |||
* To ensure consistent and complete cleanup of managed clusters and their associated resources during cluster or node deletion, you must configure ArgoCD to use background deletion mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The asterisk is related to the 300 node section it seems. If we're removing the only two points from the Limits and requirements, shouldn't we remove the whole section or mark it as empty for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To ensure consistent and complete cleanup of managed clusters and their associated resources during cluster or node deletion, you must configure ArgoCD to use background deletion mode.
So this bullet point doesn't make sense as a standalone point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The limit on how many nodes can be handled by one argocd app was moved to the scaling section for consistency with other scaling targets. However the other bullet point here is not related to the scale, but rather the requirement that argocd be configured in background deletion mode.
I think it still makes sense as standalone, but if there is more context needed we can add that here.
@rohennes: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
TELCODOCS-2284: Updates for 4.19 hub cluster with GA support
This bumps the software versions.
Adds content based on the upstream MR.
Bumps instances of 4.18 to 4.19.
Removes TP note
Version(s):
4.19+
Issue:
https://issues.redhat.com/browse/TELCODOCS-2284
Link to docs preview:
QE review: