Skip to content

Conversation

@gouthampacha
Copy link

Add documentation for manila csi changes
to allow multiple access rules

Add documentation for manila csi changes
to allow multiple access rules
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 17, 2025

@gouthampacha: This pull request references OSASINFRA-3718 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.21.0" version, but no target version was set.

In response to this:

Add documentation for manila csi changes
to allow multiple access rules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 17, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 17, 2025

Copy link
Contributor

@maxwelldb maxwelldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good start. TYVM! I'll have some mod docs stuff to add later.

Comment on lines +89 to +107
[NOTE]
====
The `nfs-ShareClient` parameter accepts various formats:
* Single IP address: `192.168.1.100`
* CIDR subnet: `10.0.0.0/24`
* Multiple entries: `10.0.0.0/24,192.168.1.100,172.16.0.0/16`
Ensure that the specified IP addresses or subnets include the {product-title} cluster nodes to allow proper mounting of the persistent volumes.
====

[IMPORTANT]
====
When using custom storage classes with restricted access rules, ensure that:
* The specified IP addresses or subnets include all {product-title} nodes that need to access the storage.
* The Manila service in {rh-openstack} supports the share type specified in the storage class.
* Network connectivity exists between the allowed clients and the Manila share servers.
====
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll likely break this out into an additional little module. Very good start though!

@maxwelldb maxwelldb self-requested a review September 17, 2025 19:24
@openshift-ci
Copy link

openshift-ci bot commented Sep 17, 2025

@gouthampacha: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.21 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.20. And any PR going into main must also target the latest version branch (enterprise-4.21).

If the update in your PR does NOT apply to version 4.21 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2025
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.20 branch/enterprise-4.21 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants