Skip to content

OSDOCS-16026 4 category restructure #99978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jmanthei wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OSDOCS-16026 4 category restructure #99978

jmanthei wants to merge 1 commit into from

Conversation

@jmanthei
Copy link
Contributor

@jmanthei jmanthei commented Oct 3, 2025 •
edited
Loading

Version(s): 4.20

Issue: https://issues.redhat.com/browse/OSDOCS-16026

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 3, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 3, 2025 •
edited
Loading

🤖 Fri Oct 10 15:43:30 - Prow CI generated the docs preview:
https://99978--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 3, 2025
@jmanthei jmanthei force-pushed the OSDOCS-16026-4cat branch 2 times, most recently from 7c73a55 to db7ff29 Compare October 3, 2025 02:21
@jmanthei
Copy link
Contributor Author

jmanthei commented Oct 3, 2025

/retest

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 3, 2025
@jmanthei jmanthei force-pushed the OSDOCS-16026-4cat branch 9 times, most recently from 59d9b5b to 15b7cbd Compare October 8, 2025 20:45
EricPonvelle
EricPonvelle reviewed Oct 8, 2025
View reviewed changes
@jmanthei jmanthei force-pushed the OSDOCS-16026-4cat branch 8 times, most recently from 079c63f to 944d4bd Compare October 10, 2025 14:47
@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2025

@jmanthei: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jmanthei
Copy link
Contributor Author

jmanthei commented Oct 10, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 10, 2025
JoeAldinger
JoeAldinger reviewed Oct 13, 2025
View reviewed changes
Copy link
Contributor

@JoeAldinger JoeAldinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few deal breakers, see the comments. Also we need to get QE and SME review of this PR before it can merge. We also need this to go back to 4.17 to mirror the larger networking reorg. Can you also provide an outline in your additional details for reviewers to look at and compare so we can tell what the structure of the reorg should be, please.

networking/ingress_load_balancing/routes/route-configuration.adoc
@@ -1,6 +1,4 @@
:_mod-docs-content-type: ASSEMBLY
// Assembly filename:route-configuration.adoc
// Explains route configuration.
Copy link
Contributor

@JoeAldinger JoeAldinger Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entire assembly is not being used now and needs to be removed from the PR and repo.

Copy link
Contributor

@JoeAldinger JoeAldinger Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't see where /nw-ingress-sharding-route-configuration.adoc is being used in this reorg.

@JoeAldinger JoeAldinger added this to the Continuous Release milestone Oct 13, 2025
@JoeAldinger JoeAldinger removed the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 13, 2025
@bergerhoffer
Copy link
Contributor

bergerhoffer commented Oct 20, 2025

The branch/enterprise-4.21 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.20. And any PR going into main must also target the latest version branch (enterprise-4.21).

If the update in your PR does NOT apply to version 4.21 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EricPonvelle EricPonvelle EricPonvelle left review comments

@JoeAldinger JoeAldinger JoeAldinger left review comments

Assignees

No one assigned

Labels

branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 branch/enterprise-4.21 size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

5 participants

@jmanthei @ocpdocs-previewbot @bergerhoffer @EricPonvelle @JoeAldinger