OCPBUGS-59907: Improve egressIP skip "Test not applicable for proxy setup" #249

MiguelCarpio · 2025-08-05T11:30:03Z

What does this PR do?
Update the egressIP skip "Test not applicable for proxy setup" skipping the test if the env variable HTTP_PROXY or HTTPS_PROXY is set, which means there is a proxy to access the Cloud.

Why do we need it?
The egressIP test doesn't support Cloud/Cluster Infrastructures that are behind a proxy because in those environments the floatingIP/egressIP is a private IP.

openshift-ci · 2025-08-05T11:30:07Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2025-08-05T11:30:09Z

@MiguelCarpio: This pull request references Jira Issue OCPBUGS-59907, which is invalid:

expected the bug to target either version "4.14." or "openshift-4.14.", but it targets "4.20.0" instead
expected Jira Issue OCPBUGS-59907 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Adapt egressIP tests to ipv6primary and ipv4primary dualstack cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-08-05T11:31:19Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign itzikb-redhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

MiguelCarpio · 2025-08-05T11:32:26Z

/jira refresh

openshift-ci-robot · 2025-08-05T11:32:31Z

@MiguelCarpio: This pull request references Jira Issue OCPBUGS-59907, which is invalid:

expected Jira Issue OCPBUGS-59907 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

MiguelCarpio · 2025-08-05T11:34:39Z

/test e2e-openstack-dualstack-techpreview

MiguelCarpio · 2025-08-05T12:48:20Z

/test e2e-openstack-dualstack-techpreview

MiguelCarpio · 2025-08-05T13:58:53Z

/test e2e-openstack-dualstack-techpreview

MiguelCarpio · 2025-08-05T17:45:34Z

/test e2e-openstack-dualstack-techpreview

MiguelCarpio · 2025-08-05T19:58:12Z

/test e2e-openstack-dualstack-techpreview

MiguelCarpio · 2025-08-06T05:57:37Z

/test e2e-openstack-dualstack-techpreview

MiguelCarpio · 2025-08-06T09:45:22Z

/test e2e-openstack-dualstack-techpreview

MiguelCarpio · 2025-08-06T12:34:18Z

/test e2e-openstack-dualstack-techpreview

MiguelCarpio · 2025-08-06T12:37:29Z

/jira refresh

openshift-ci-robot · 2025-08-06T12:37:33Z

@MiguelCarpio: This pull request references Jira Issue OCPBUGS-59907, which is invalid:

expected the bug to target only the "4.14.z" version, but multiple target versions were set
expected Jira Issue OCPBUGS-59907 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

MiguelCarpio · 2025-08-06T12:38:15Z

/jira refresh

openshift-ci-robot · 2025-08-06T12:38:19Z

@MiguelCarpio: This pull request references Jira Issue OCPBUGS-59907, which is invalid:

expected Jira Issue OCPBUGS-59907 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

MiguelCarpio · 2025-08-06T12:38:47Z

/jira refresh

openshift-ci-robot · 2025-08-06T12:39:07Z

@MiguelCarpio: This pull request references Jira Issue OCPBUGS-59907, which is invalid:

expected the bug to target the "4.14.z" version, but no target version was set
expected Jira Issue OCPBUGS-59907 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

MiguelCarpio · 2025-08-06T12:41:31Z

/jira refresh

openshift-ci-robot · 2025-08-06T12:41:35Z

@MiguelCarpio: This pull request references Jira Issue OCPBUGS-59907, which is invalid:

expected dependent Jira Issue OCPBUGS-27222 to target a version in 4.15.0, 4.15.z, but it targets "4.16.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

MiguelCarpio · 2025-08-06T12:44:09Z

/jira refresh

openshift-ci-robot · 2025-08-06T12:44:16Z

@MiguelCarpio: This pull request references Jira Issue OCPBUGS-59907, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.z) matches configured target version for branch (4.14.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-42542 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-42542 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

MiguelCarpio · 2025-08-06T15:31:04Z

/test e2e-openstack-dualstack-techpreview

MiguelCarpio · 2025-08-06T18:32:17Z

/test e2e-openstack-dualstack-techpreview

openshift-ci-robot · 2025-08-07T05:51:53Z

@MiguelCarpio: This pull request references Jira Issue OCPBUGS-59907, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.z) matches configured target version for branch (4.14.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-42542 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-42542 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What does this PR do?
Update the egressIP skip "Test not applicable for proxy setup" skipping the test if the env variable HTTP_PROXY or HTTPS_PROXY is set, which means there is a proxy to access the Cloud.

Why do we need it?
The egressIP test doesn't support Cloud/Cluster Infrastructures that are behind a proxy because in those environments, the floatingIP/egressIP is a private IP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

MiguelCarpio · 2025-08-07T05:57:24Z

/assign @mandre

mandre · 2025-08-07T06:46:57Z

test/extended/openstack/egressip.go

 		proxy, err := oc.AdminConfigClient().ConfigV1().Proxies().Get(ctx, "cluster", metav1.GetOptions{})
 		o.Expect(err).NotTo(o.HaveOccurred())
-		if proxy.Status.HTTPProxy != "" {
+		if os.Getenv("HTTP_PROXY") != "" || os.Getenv("HTTPS_PROXY") != "" || proxy.Status.HTTPProxy != "" {


Can you explain what the difference is between checking for the HTTP(S)_PROXY environment variable and proxy.Status.HTTPProxy ?

If we need to add more conditions to know if the test runs behind a proxy, perhaps it's time to introduce a function for it and make it consistent across all the tests?

openshift-ci · 2025-08-07T08:39:56Z

@MiguelCarpio: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

stephenfin · 2025-10-06T17:08:27Z

/assign

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2025

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 5, 2025

MiguelCarpio force-pushed the release-4.14 branch from d7657e5 to a4e3600 Compare August 6, 2025 05:55

Improve egressIP skip "Test not applicable for proxy setup"

c634dc9

MiguelCarpio force-pushed the release-4.14 branch from efd35bd to c634dc9 Compare August 6, 2025 12:33

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 6, 2025

MiguelCarpio changed the title ~~OCPBUGS-59907: Adapt egressIP tests to ipv6primary and ipv4primary dualstack cluster~~ OCPBUGS-59907: Improve egressIP skip "Test not applicable for proxy setup" Aug 6, 2025

MiguelCarpio mentioned this pull request Aug 6, 2025

OCPBUGS-59907: Skip egressIP openstack test for 4.14-e2e-openstack-dualstack-techpreview jobs openshift/release#67608

Closed

MiguelCarpio marked this pull request as ready for review August 7, 2025 05:52

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2025

openshift-ci bot requested review from EmilienM and mandre August 7, 2025 05:52

openshift-ci bot assigned mandre Aug 7, 2025

mandre reviewed Aug 7, 2025

View reviewed changes

openshift-ci bot assigned stephenfin Oct 6, 2025

OCPBUGS-59907: Improve egressIP skip "Test not applicable for proxy setup" #249

Are you sure you want to change the base?

OCPBUGS-59907: Improve egressIP skip "Test not applicable for proxy setup" #249

Uh oh!

Conversation

MiguelCarpio commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Aug 5, 2025

Uh oh!

openshift-ci-robot commented Aug 5, 2025

Uh oh!

openshift-ci bot commented Aug 5, 2025

Uh oh!

MiguelCarpio commented Aug 5, 2025

Uh oh!

openshift-ci-robot commented Aug 5, 2025

Uh oh!

MiguelCarpio commented Aug 5, 2025

Uh oh!

MiguelCarpio commented Aug 5, 2025

Uh oh!

MiguelCarpio commented Aug 5, 2025

Uh oh!

MiguelCarpio commented Aug 5, 2025

Uh oh!

MiguelCarpio commented Aug 5, 2025

Uh oh!

MiguelCarpio commented Aug 6, 2025

Uh oh!

MiguelCarpio commented Aug 6, 2025

Uh oh!

MiguelCarpio commented Aug 6, 2025

Uh oh!

MiguelCarpio commented Aug 6, 2025

Uh oh!

openshift-ci-robot commented Aug 6, 2025

Uh oh!

MiguelCarpio commented Aug 6, 2025

Uh oh!

openshift-ci-robot commented Aug 6, 2025

Uh oh!

MiguelCarpio commented Aug 6, 2025

Uh oh!

openshift-ci-robot commented Aug 6, 2025

Uh oh!

MiguelCarpio commented Aug 6, 2025

Uh oh!

openshift-ci-robot commented Aug 6, 2025

Uh oh!

MiguelCarpio commented Aug 6, 2025

Uh oh!

openshift-ci-robot commented Aug 6, 2025

Uh oh!

MiguelCarpio commented Aug 6, 2025

Uh oh!

MiguelCarpio commented Aug 6, 2025

Uh oh!

openshift-ci-robot commented Aug 7, 2025

Uh oh!

MiguelCarpio commented Aug 7, 2025

Uh oh!

mandre Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Aug 7, 2025

Uh oh!

stephenfin commented Oct 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MiguelCarpio commented Aug 5, 2025 •

edited

Loading