WIP: Add disruption check for Thanos Querier API #29391
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uncertain if the SLO is achievable with the current config (a check every second) API adjustments may be needed to improve reliability, or we may need to loosen up the check Based on Route dependency, which could increase the likelihood of false positives. Auth isn't set; we only check for 401. A 5xx would indicate Route backend (Thanos Querier Pods) issues. We may be able to easily get token based auth to work
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: machine424 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
machine424
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@machine424: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: 432ee31
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 432ee31
New tests seen in this PR at sha: 432ee31
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed here #28737 (comment)
Thanos querier API is the principal/wrapping API to fetch metrics. Given all the consumers that depend on it, it would be interesting to see how it performs.
Uncertain if the SLO is achievable with the current config (a check every second) API adjustments may be needed to improve reliability, or we may need to loosen up the check
Based on Route dependency, which could increase the likelihood of false positives.
Auth isn't set; we only check for 401. A 5xx would indicate Route backend (Thanos Querier Pods) issues. We may be able to easily get token based auth to work