Skip to content

[WIP] revert: Increase pod readiness timeout #29486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −11
Open

[WIP] revert: Increase pod readiness timeout #29486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions test/extended/networking/network_segmentation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,6 @@ import (
const openDefaultPortsAnnotation = "k8s.ovn.org/open-default-ports"
const RequiredUDNNamespaceLabel = "k8s.ovn.org/primary-user-defined-network"

// NOTE: We are observing pod creation requests taking more than two minutes t
// reach the CNI for the CNI to do the necessary plumbing. This is causing tests
// to timeout since pod doesn't go into ready state.
// See https://issues.redhat.com/browse/OCPBUGS-48362 for details. We can revisit
// these values when that bug is fixed but given the Kubernetes test default for a
// pod to startup is 5mins: https://github.com/kubernetes/kubernetes/blob/60c4c2b2521fb454ce69dee737e3eb91a25e0535/test/e2e/framework/timeouts.go#L22-L23
// we are not too far from the mark or against test policy
const podReadyPollTimeout = 4 * time.Minute
const podReadyPollInterval = 6 * time.Second

// NOTE: Upstream, we use either the default of gomega which is 1sec polltimeout with 10ms pollinterval OR
// the tests have hardcoded values with 5sec being common for polltimeout and 10ms for pollinterval
// This is being changed to be 10seconds poll timeout to account for infrastructure complexity between
Expand Down Expand Up @@ -1848,7 +1838,7 @@ func runUDNPod(cs clientset.Interface, namespace string, podConfig podConfigurat
return v1.PodFailed
}
return updatedPod.Status.Phase
}, podReadyPollTimeout, podReadyPollInterval).Should(Equal(v1.PodRunning))
}, 2*time.Minute, 6*time.Second).Should(Equal(v1.PodRunning))
return updatedPod
}

Expand Down