Skip to content

[SDCICD-1704] add cluster id and expiration to message #3065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
christophermancini wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[SDCICD-1704] add cluster id and expiration to message #3065

christophermancini wants to merge 1 commit into from

Conversation

@christophermancini
Copy link

@christophermancini christophermancini commented Dec 10, 2025 •
edited
Loading

Add cluster ID and expiration to PR message.

Also:

  • add some new test coverage
  • add support to send API slack messages with attached log files with token
  • fall back to embedding log stdout into the message payload, showing up to 150 lines
  • if over 150 lines, show first 50 and last 100 lines

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christophermancini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2025
@christophermancini christophermancini marked this pull request as ready for review January 8, 2026 21:20
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2026
@openshift-ci openshift-ci bot requested review from minlei98 and ritmun January 8, 2026 21:20
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2026
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2026
@christophermancini
[SDCICD-1704] add cluster id and expiration to message
4511f85 
- add ability to use Slack API and attach log files, requires slack api token
- falls back to webhook message
- show all logs up to 150 lines in message payload
- if greater than 150, show first 50 and last 100. Add test coverage.
- add test coverage
- fix lint and formatting errors
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 8, 2026

@christophermancini: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@minlei98 minlei98 Awaiting requested review from minlei98

@ritmun ritmun Awaiting requested review from ritmun

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@christophermancini @openshift-merge-robot