Skip to content

OCM-00000 | ci: Update github.com/nathan-fiscaletti/consolesize-go digest to 3bac975#3247

Closed
red-hat-konflux[bot] wants to merge 1 commit into
masterfrom
konflux/mintmaker/master/github.com-nathan-fiscaletti-consolesize-go-digest
Closed

OCM-00000 | ci: Update github.com/nathan-fiscaletti/consolesize-go digest to 3bac975#3247
red-hat-konflux[bot] wants to merge 1 commit into
masterfrom
konflux/mintmaker/master/github.com-nathan-fiscaletti-consolesize-go-digest

Conversation

@red-hat-konflux

@red-hat-konflux red-hat-konflux Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Type Update Change
github.com/nathan-fiscaletti/consolesize-go require digest a87d9f63bac975

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@red-hat-konflux red-hat-konflux Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 25, 2026
@coderabbitai

coderabbitai Bot commented May 25, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 802e16dd-b910-4886-a8ea-09f6b50611bc

📥 Commits

Reviewing files that changed from the base of the PR and between 1d1b02a and a8308a3.

⛔ Files ignored due to path filters (5)
  • go.sum is excluded by !**/*.sum
  • vendor/github.com/nathan-fiscaletti/consolesize-go/README.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/nathan-fiscaletti/consolesize-go/consolesize_unix.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/nathan-fiscaletti/consolesize-go/consolesize_windows.go is excluded by !**/vendor/**, !vendor/**
  • vendor/modules.txt is excluded by !**/vendor/**, !vendor/**
📒 Files selected for processing (1)
  • go.mod

Walkthrough

This PR updates the github.com/nathan-fiscaletti/consolesize-go dependency in go.mod to a newer version. No other module requirements are modified.

Changes

Dependency Update

Layer / File(s) Summary
consolesize-go dependency bump
go.mod
The consolesize-go dependency is updated from v0.0.0-20210105204122-a87d9f614b9d to v0.0.0-20260406063853-3bac975de715.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

approved, lgtm

Suggested reviewers

  • gdbranco
  • jerichokeyne
🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is auto-generated by a dependency update tool (Renovate/MintMaker) and lacks required sections from the template such as Detailed Description, Type of Change checkbox, Behavior changes, Testing steps, and Developer Verification Checklist. Add required sections from the template: explicitly check the 'ci' type checkbox, provide testing instructions, and complete the Developer Verification Checklist items applicable to this dependency update.
✅ Passed checks (11 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the commit format requirement with JIRA ticket and TYPE prefix, and accurately describes the primary change: updating a dependency digest.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed All 500+ Ginkgo test names examined are stable and deterministic with static, descriptive strings; no dynamic content, interpolation, or variable names found in test titles.
Test Structure And Quality ✅ Passed PR updates go.mod dependency and removes test code; custom check applies only to new/modified test code that might violate Ginkgo quality standards. Removals are not subject to this check.
Microshift Test Compatibility ✅ Passed PR only updates go.mod dependency version; no new Ginkgo e2e tests added, so MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only updates go.mod dependency (consolesize-go), no new Ginkgo e2e tests are added. Custom check for SNO test compatibility applies only when new tests are added.
Topology-Aware Scheduling Compatibility ✅ Passed PR only updates consolesize-go dependency in go.mod; no deployment manifests, operator code, controllers, or scheduling constraints are added/modified.
Ote Binary Stdout Contract ✅ Passed The consolesize-go update is safe—it queries console size via syscalls only, never writes to stdout, and is called within command handlers, not process-level code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR only updates the consolesize-go dependency in go.mod (+1/-1 line change). No new Ginkgo e2e tests are added, so the IPv6/disconnected network compatibility check does not apply.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch konflux/mintmaker/master/github.com-nathan-fiscaletti-consolesize-go-digest

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci

openshift-ci Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: red-hat-konflux[bot]
Once this PR has been reviewed and has the lgtm label, please assign jerichokeyne for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor

Hi @red-hat-konflux[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@olucasfreitas

Copy link
Copy Markdown
Contributor

/ok-to-test

@amandahla

amandahla commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

@olucasfreitas I'll close this PR to force Renovate creating a new one, I dont know why the commitMessagePrefix was ignored here.
@coderabbitai any ideas?

correction: I cant close the PR, I lost permission here.

@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Look for Renovate/MintMaker configuration files
fd -i "renovate" --type f
fd -i "mintmaker" --type f
fd -i ".renovaterc" --type f

# Check common renovate config locations
cat renovate.json 2>/dev/null || echo "No renovate.json found"
cat .renovaterc 2>/dev/null || echo "No .renovaterc found"
cat .renovaterc.json 2>/dev/null || echo "No .renovaterc.json found"

# Check if there's a renovate config in .github
ls .github/ 2>/dev/null
cat .github/renovate.json 2>/dev/null || echo "No .github/renovate.json found"
cat .github/renovate.json5 2>/dev/null || echo "No .github/renovate.json5 found"

Length of output: 812


🏁 Script executed:

#!/bin/bash
# Check the PR description and details
gh pr view 3247 --repo openshift/rosa --json title,body,labels,author,headRefName

# Search for any dependency update configuration
fd -e json --type f | head -30
fd -e yaml --type f -g "*renovate*" 
fd -e yaml --type f -g "*mintmaker*"

# Check if there's anything in the .tekton or konflux directories
ls .tekton/ 2>/dev/null || echo "No .tekton dir"
ls .konflux/ 2>/dev/null || echo "No .konflux dir"

# Look for any config mentioning commitMessagePrefix
rg -r "commitMessagePrefix" . 2>/dev/null || echo "No commitMessagePrefix found"

Length of output: 280754



@amandahla The most likely reason is that there is no Renovate/MintMaker configuration file in this repository. I searched for renovate.json, .renovaterc, .renovaterc.json, and .github/renovate.json — none exist. Without a repo-level config, MintMaker falls back to its global/default template, which is what produced the "OCM-00000 | ci:" prefix you see in this PR.

To enforce a specific commitMessagePrefix, you'd need to add a renovate.json (or .renovaterc.json) to the repo root, for example:

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "commitMessagePrefix": "YOUR-DESIRED-PREFIX | "
}

A few additional things to check:

  1. MintMaker global config: MintMaker can have an organization-level config that may take precedence over repo-level settings. Check whether there's a konflux-ci/renovate-config or similar org-level preset being inherited — it could be overriding your prefix. The MintMaker docs detail how to override global settings.

  2. commitMessagePrefix vs commitMessageTopic: Renovate's commitMessagePrefix sets the prefix before the semantic type (e.g. fix:). If you want to control what comes before that, you may need additionalBranchPrefix or a custom commitMessage template instead, depending on exactly what format you want.

  3. Branch already existed: Since this PR's branch (konflux/mintmaker/master/...) was already created without the prefix, closing it and letting MintMaker recreate it (after adding the config) is the right approach — which you mentioned. If you no longer have permission to close this PR, another team member with write access would need to do it, or you could add the renovate.json config and check the "rebase/retry" checkbox in the PR description to trigger a recreation.

@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Look for Renovate configuration files
fd -t f -e json -e yaml -e yml renovate
echo "---"
fd -t f "\.renovaterc" 
echo "---"
# Check package.json for renovate config
cat package.json 2>/dev/null | python3 -c "import sys,json; d=json.load(sys.stdin); print(json.dumps(d.get('renovate', {}), indent=2))" 2>/dev/null || echo "No package.json renovate config"
echo "---"
# Check for mintmaker config
fd -t f mintmaker
echo "---"
fd -t f -e json -e yaml -e yml "\.mintmaker"

Length of output: 575


🏁 Script executed:

#!/bin/bash
# Check .github directory
ls -la .github/ 2>/dev/null || echo "No .github dir"
echo "---"
# Look for any config files in .github
find .github -type f 2>/dev/null
echo "---"
# Check if there's a .renovaterc.json or similar at root
ls -la .renovate* 2>/dev/null || echo "No .renovate* files"
ls -la *.json 2>/dev/null | head -20
echo "---"
# Check git log for recent Renovate/MintMaker commits to see if prefix was used before
git log --oneline --all | grep -i "renovate\|mintmaker\|konflux" | head -20
echo "---"
# Check the PR branch name for context
git branch -a | grep -i "mintmaker\|renovate\|konflux"

Length of output: 2179


🏁 Script executed:

#!/bin/bash
# Check the commit that configured Renovate for ROSA CLI
git show --stat 18f2fc66
echo "---"
# See what files were changed in that commit
git show 18f2fc66 -- "*.json" "*.yaml" "*.yml" 2>/dev/null
echo "---"
# Also check if there's a mintmaker or renovate config anywhere in the tree
find . -name "*.json" -not -path "./.git/*" | xargs grep -l "commitMessagePrefix\|renovate\|mintmaker" 2>/dev/null
echo "---"
# Check gh CLI for the PR that added Renovate config
gh pr view 3247 --json title,body,headRefName,commits | python3 -c "import sys,json; d=json.load(sys.stdin); print('Title:', d['title']); print('Branch:', d['headRefName']); [print('Commit:', c['messageHeadline']) for c in d.get('commits',{}).get('nodes',[])]"

Length of output: 5929


🏁 Script executed:

#!/bin/bash
# Check the current state of renovate.json on master
git show origin/master:renovate.json 2>/dev/null || echo "renovate.json not on master"
echo "---"
# Also check if there were any recent changes to renovate.json
git log --oneline origin/master -- renovate.json 2>/dev/null | head -10
echo "---"
# Check when this PR branch was created vs when renovate.json was added
git log --oneline --all | head -30
echo "---"
# Look at the actual commit on the PR branch
git log --oneline HEAD | head -5

Length of output: 6595



@amandahla — Here's what happened:

The underlying commit on this PR branch is:

a8308a35 Update github.com/nathan-fiscaletti/consolesize-go digest to 3bac975

No prefix. The PR title (OCM-00000 | ci: Update ...) does have the prefix because Renovate retroactively updated the PR title when it picked up the new renovate.json config — but it cannot rewrite the existing commit message on the already-created branch.

The root cause is a race condition between when MintMaker created the branch/commit and when renovate.json (with "commitMessagePrefix": "OCM-00000 | ci: ") was merged into master:

  1. renovate.json was introduced in #3244 (18f2fc66) and then updated in 822dc3e6 (OCM-24531 — scoping tekton automerge to .tekton/)
  2. MintMaker had already created the branch commit (a8308a35) before it picked up the new config
  3. On the next Renovate run, it updated the PR title but left the commit as-is

Closing this PR and letting MintMaker recreate it is exactly the right fix — the new branch will be minted after the config is fully in place, so the commit message will correctly carry the OCM-00000 | ci: prefix from the start.

@red-hat-konflux

Copy link
Copy Markdown
Contributor Author

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for the github.com/nathan-fiscaletti/consolesize-go 3bac975 update again.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@red-hat-konflux red-hat-konflux Bot deleted the konflux/mintmaker/master/github.com-nathan-fiscaletti-consolesize-go-digest branch June 2, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants