Skip to content

OCM-00000 | ci: Update module github.com/dchest/validator to v1#3308

Closed
red-hat-konflux[bot] wants to merge 1 commit into
masterfrom
konflux/mintmaker/master/github.com-dchest-validator-1.x
Closed

OCM-00000 | ci: Update module github.com/dchest/validator to v1#3308
red-hat-konflux[bot] wants to merge 1 commit into
masterfrom
konflux/mintmaker/master/github.com-dchest-validator-1.x

Conversation

@red-hat-konflux

@red-hat-konflux red-hat-konflux Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
github.com/dchest/validator v0.0.0-20191217151620-8e45250f2371v1.0.0 age confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

Summary by CodeRabbit

  • Chores
    • Updated the Go toolchain version used by the project.
    • Refreshed a validation library to a stable released version.

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@red-hat-konflux red-hat-konflux Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 1, 2026
@red-hat-konflux

Copy link
Copy Markdown
Contributor Author

ℹ️ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • The go directive was updated for compatibility reasons

Details:

Package Change
go 1.25.8 -> 1.26.1

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b0ed223f-991e-40d4-83bc-3f48ff24ec30

📥 Commits

Reviewing files that changed from the base of the PR and between e6c81eb and aace30b.

⛔ Files ignored due to path filters (5)
  • go.sum is excluded by !**/*.sum
  • vendor/github.com/dchest/validator/.travis.yml is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/dchest/validator/README.md is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/dchest/validator/domain.go is excluded by !vendor/**, !**/vendor/**
  • vendor/modules.txt is excluded by !vendor/**, !**/vendor/**
📒 Files selected for processing (1)
  • go.mod

📝 Walkthrough

Walkthrough

This pull request updates go.mod, bumping the Go toolchain directive from 1.25.8 to 1.26.1 and updating the github.com/dchest/validator dependency from a pseudo-version to the released v1.0.0.

Changes

File Summary
go.mod Bumped Go directive to 1.26.1; updated github.com/dchest/validator to v1.0.0

Sequence Diagram(s)

Not applicable for this change.

Suggested reviewers: BraeTroutman, olucasfreitas

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description notes the dependency bump but misses the required template sections for summary, issues, testing, and verification. Rewrite the PR body using the template and add the missing sections, or mark non-applicable items as N/A.
✅ Passed checks (14 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the dependency update shown in go.mod and identifies the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The PR only changes go.mod (toolchain and validator dependency); no Ginkgo test titles were added or modified.
Test Structure And Quality ✅ Passed PR only updates go.mod/vendor files; no *_test.go or Ginkgo specs were changed, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed Only go.mod was updated (toolchain/dependency); no new Ginkgo specs or MicroShift-sensitive test code were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: This PR only updates go.mod/dependency versions; it doesn't add or modify Ginkgo e2e tests, so SNO compatibility review isn't applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only go.mod/toolchain and a library version changed; no manifests, controllers, or scheduling constraints were modified.
Ote Binary Stdout Contract ✅ Passed PR only updates go.mod/validator; no process-level stdout writes were added, and cmd/rosa/main.go writes errors to stderr.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR only updates go.mod (validator version and Go directive); no new Ginkgo e2e tests or network-dependent test changes were added.
No-Weak-Crypto ✅ Passed PR diff only updates go.mod/go.sum; scanned added lines and validator code for flagged crypto/comparison patterns and found none.
Container-Privileges ✅ Passed PR only changes go.mod/go.sum and vendored validator files; no container/K8s manifests or privilege settings were introduced.
No-Sensitive-Data-In-Logs ✅ Passed Only go.mod was updated for a dependency/toolchain bump; no logging code or sensitive-data outputs were added.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch konflux/mintmaker/master/github.com-dchest-validator-1.x

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from davidleerh and jerichokeyne July 1, 2026 15:08
@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: red-hat-konflux[bot]
Once this PR has been reviewed and has the lgtm label, please assign gdbranco for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Hi @red-hat-konflux[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

@red-hat-konflux[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lint aace30b link true /test lint
ci/prow/security aace30b link false /test security
ci/prow/test aace30b link true /test test
ci/prow/build aace30b link true /test build

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@red-hat-konflux

Copy link
Copy Markdown
Contributor Author

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 1.x releases. But if you manually upgrade to 1.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@red-hat-konflux red-hat-konflux Bot deleted the konflux/mintmaker/master/github.com-dchest-validator-1.x branch July 1, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant