Skip to content

[WIP] Migrate operator_test to OTE style #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ropatil010 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[WIP] Migrate operator_test to OTE style #595

ropatil010 wants to merge 2 commits into from

Conversation

@ropatil010
Copy link
Contributor

@ropatil010 ropatil010 commented Jan 6, 2026

Hi Team,

As per below discussions raised this PR. Goal to migrate standard go format operator_test.go to ginkgo format.

  1. https://redhat-internal.slack.com/archives/CS05TR7BK/p1767591870151539
  2. https://redhat-internal.slack.com/archives/CC3CZCQHM/p1767592728303979

/hold

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ropatil010
Once this PR has been reviewed and has the lgtm label, please assign ardaguclu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ropatil010
Copy link
Contributor Author

ropatil010 commented Jan 7, 2026

/unhold
/assign @wangke19 @gangwgr @sandeepknd

@ropatil010 ropatil010 changed the title [WIP]Migrate operator_test to OTE style Migrate operator_test to OTE style Jan 7, 2026
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2026
@ropatil010
Copy link
Contributor Author

ropatil010 commented Jan 7, 2026

CI Execution logs:
https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_run-once-duration-override-operator/595/pull-ci-openshift-run-once-duration-override-operator-main-e2e-aws-operator/2008877836659593216/artifacts/e2e-aws-operator/test/build-log.txt

Local system execution,
Standard Go Test Framework, it fails bec it needs to be installed from marketplace

export NAMESPACE=openshift-run-once-duration-override-test KUBECONFIG=/home/ropatil/Downloads/kubeconfig RELEASE_IMAGE_LATEST=registry.ci.openshift.org/ocp/release:4.21.0-0.nightly-2026-01-06-165528 && go test -v ./test/e2e -timeout=3h 
=== RUN   TestExtended
=== RUN   TestExtended/RunOnceDurationOverride_Operator

OTE Framework

./_output/bin/run-once-duration-override-operator-tests-ext run-suite openshift/run-once-duration-override-operator/conformance/serial
OR 
./_output/bin/run-once-duration-override-operator-tests-ext run-test "[sig-scheduling][Operator][Serial] RunOnceDurationOverride Operator when webhook is active should set ActiveDeadlineSeconds on pods in labeled namespaces [Suite:openshift/run-once-duration-override-operator/conformance/serial]"

More detailed wrt execution is mentioned in the test/e2e/README.md file

wangke19
wangke19 reviewed Jan 7, 2026
View reviewed changes
@wangke19
Copy link

wangke19 commented Jan 8, 2026 •
edited
Loading

@ropatil010 Better to split this PR into two. You can refer to PRs openshift/service-ca-operator#295 and openshift/service-ca-operator#297. Reduce code lines of each PR, easy to review.

@wangke19
Copy link

wangke19 commented Jan 8, 2026

For CI job, e2e-aws-operator is based on test/e2e/operator_test.go, so migration tests of OTE also needs one similar CI job, we add it in https://github.com/openshift/release/blob/master/ci-operator/config/openshift/run-once-duration-override-operator/openshift-run-once-duration-override-operator-main.yaml. Once migration tests run stably, we will remove CI job https://github.com/openshift/release/blob/master/ci-operator/config/openshift/run-once-duration-override-operator/openshift-run-once-duration-override-operator-main.yaml#L43 and related test/e2e/operator_test.go.

@ropatil010 ropatil010 changed the title Migrate operator_test to OTE style [WIP] Migrate operator_test to OTE style Jan 8, 2026
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2026
@ropatil010 ropatil010 force-pushed the add-otetests branch 2 times, most recently from 7885884 to 1565aee Compare January 8, 2026 10:50
@ropatil010 ropatil010 mentioned this pull request Jan 8, 2026
Open
wangke19
wangke19 reviewed Jan 9, 2026
View reviewed changes
wangke19
wangke19 reviewed Jan 9, 2026
View reviewed changes
wangke19
wangke19 reviewed Jan 13, 2026
View reviewed changes
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2026
Rohit Patil and others added 2 commits January 13, 2026 15:58
@ropatil010
cmd/README: add OTE infrastructure and update test suite configuration
40045bb 
This commit introduces the OpenShift Tests Extension framework infrastructure
for Run Once Duration Override Operator tests. The changes include:

- Updating the README.md Tests section to follow OTE conventions with examples
- Updating test suite path from /all to /operator/serial
- Refactoring cmd/run-once-duration-override-operator-tests-ext/main.go with
  proper error handling
- Adding prepareOperatorTestsRegistry for OTE test suite configuration
- Defining the operator/serial suite with [Operator] and [Serial] tags

Co-Authored-By: Rohit Patil <[email protected]>
@ropatil010
vendor: update dependencies for OTE/Ginkgo support
d34ce2a 
Updates dependencies required for OTE framework integration, including:

- Adding github.com/onsi/ginkgo/v2 with OpenShift fork replace directive
  (v2.6.1-0.20251001123353-fd5b1fb35db1) for OCP 4.21 compatibility
- Adding github.com/onsi/gomega for Ginkgo matchers
- Adding github.com/openshift-eng/openshift-tests-extension for OTE framework
- Adding supporting dependencies (go-task/slim-sprig, google/pprof, golang.org/x/*)
- Updating go.mod and go.sum with new dependencies
- Updating vendor/modules.txt and vendoring all new dependencies

Co-Authored-By: Rohit Patil <[email protected]>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2026

@ropatil010: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ropatil010
Copy link
Contributor Author

ropatil010 commented Jan 13, 2026

Hi @wangke19 Fixed per suggestion. Can you PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

1 more reviewer

@wangke19 wangke19 wangke19 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@wangke19 wangke19

@sandeepknd sandeepknd

@gangwgr gangwgr

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ropatil010 @wangke19 @openshift-merge-robot @sandeepknd @gangwgr