Skip to content

CNTRLPLANE-2471: refactor(pkg/operator/targetconfigcontroller): flip to generated applyconfiguration client code for status updating #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ingvagabund wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CNTRLPLANE-2471: refactor(pkg/operator/targetconfigcontroller): flip to generated applyconfiguration client code for status updating #628

ingvagabund wants to merge 1 commit into from

Conversation

@ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Jan 13, 2026

ssia

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 13, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2026 •
edited by openshift-ci bot
Loading

@ingvagabund: This pull request references CNTRLPLANE-2471 which is a valid jira issue.

Details

In response to this:

ssia

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2026
@openshift-ci openshift-ci bot requested a review from ardaguclu January 13, 2026 12:03
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2026
@ingvagabund ingvagabund force-pushed the applyconfigurationoperatorclient branch 10 times, most recently from 5cf006d to 868ce66 Compare January 13, 2026 18:47
@ingvagabund ingvagabund added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2026
@ingvagabund ingvagabund changed the title wip: CNTRLPLANE-2471: refactor(pkg/operator/targetconfigcontroller): flip to generated applyconfiguration client code for status updating CNTRLPLANE-2471: refactor(pkg/operator/targetconfigcontroller): flip to generated applyconfiguration client code for status updating Jan 13, 2026
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2026
@ingvagabund ingvagabund force-pushed the applyconfigurationoperatorclient branch from 868ce66 to b4d7a6a Compare January 13, 2026 18:55
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2026

New changes are detected. LGTM label has been removed.

@ingvagabund ingvagabund added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2026
@ingvagabund
Copy link
Member Author

ingvagabund commented Jan 13, 2026

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 13, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2026

@ingvagabund: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2026

/retest-required

Remaining retests: 0 against base HEAD fe707e5 and 2 for PR HEAD b4d7a6a in total

@ingvagabund ingvagabund force-pushed the applyconfigurationoperatorclient branch from b4d7a6a to 9d7fb3a Compare January 13, 2026 22:11
@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Jan 13, 2026
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2026

New changes are detected. LGTM label has been removed.

@ingvagabund ingvagabund added lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria and removed lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria labels Jan 13, 2026
@ingvagabund ingvagabund force-pushed the applyconfigurationoperatorclient branch from 9d7fb3a to 67b42d1 Compare January 13, 2026 23:27
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 14, 2026

@ingvagabund: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator 67b42d1 link true /test e2e-aws-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ingvagabund @openshift-ci-robot