Allow disconnected usage of podvm-builder #1404
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
bpradipt
force-pushed
the
builder-offline
branch
from
d72776b to
b9e312f
Compare
|
@bpradipt: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This commit enables podvm image creation in Azure when using either public or private access. Additionally it also enforces security best practices for the storage account created for the podvm image. When public network access is disabled, a private endpoint is must. - Enforce minimum TLS version 1.2 - Disable cross-tenant object replication - Disable public network access - Enforce HTTPS-only connections - Disable public blob access - Create private endpoint in the same subnet (AZURE_SUBNET_ID) for blob access - Use storage account FQDN with /etc/hosts entry for proper SSL certificate validation (certificates are issued for *.blob.core.windows.net, not IPs) - Delete private endpoint before storage account cleanup Storage account and private endpoint creation is idempotent to support job retries without orphaning Azure resources: - Deterministic storage account naming using "oscsa" prefix + IMAGE_NAME - Existence checks before creating storage account and private endpoint - Hosts entry added only if not already present - Blob upload uses --overwrite flag for retry safety Assisted-by: AI Signed-off-by: Pradipta Banerjee <[email protected]>
Preinstall the artefacts for azure. Signed-off-by: Pradipta Banerjee <[email protected]>
bpradipt
force-pushed
the
builder-offline
branch
from
b9e312f to
aa4200d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preinstall the artefacts for azure.
- Description of the problem which is fixed/What is the use case
- What I did
- How to verify it
- Description for the changelog