-
Notifications
You must be signed in to change notification settings - Fork 17
SSCSI-98: Add required go build flags for FIPS #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: chiragkyal <[email protected]>
@chiragkyal: This pull request references SSCSI-98 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/hold |
/assign @arkadeepsen @mytreya-rh |
/test all |
/hold cancel |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chiragkyal, mytreya-rh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/label qe-approved |
@chiragkyal: This pull request references SSCSI-98 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
aca8e37
into
openshift:main
@chiragkyal: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description:
GOEXPERIMENT=strictfipsruntime
,CGO_ENABLED=1
, and appropriate build tags.-tags "strictfipsruntime,openssl"
go version -m
.The change will modify the
make build
target fromto
CI Changes
Note: Currently, we're relying on the ART golang builder to intercept the non-compliant flags forcefully. This PR is intended to make the binary FIPS compliant by default.