Skip to content

SSCSI-104, SSCSI-105: Implementation of Network Policy for SSCSI #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

SSCSI-104, SSCSI-105: Implementation of Network Policy for SSCSI #80

wants to merge 4 commits into from

Conversation

PillaiManish
Copy link
Contributor

@PillaiManish PillaiManish commented May 20, 2025 •
edited
Loading

This PR implements the Network Policy (OCPSTRAT-819) for the secrets-store-csi-driver operator and the operand.

File Changed:

  1. go.mod & vendor: Updating the library-go to the commit: 7de7fae so that it includes the code for network-policy
  2. Assests/*: This folder contains all the network policy required for the operand & the operator.
    • allow-egress-to-api-server-operand.yaml
    • allow-egress-to-api-server-operator.yaml
    • allow-ingress-to-metrics-operand.yaml
    • allow-ingress-to-metrics-operator.yaml
  3. Updated CSV (ClusterServiceVersion) for including network policies in permissions

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 20, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 20, 2025 •
edited by openshift-ci bot
Loading

@PillaiManish: This pull request references SSCSI-104 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references SSCSI-105 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

This PR implements the Network Policy for the secrets-store-csi-driver operator and the operand.

File Changed:

  1. go.mod & vendor: Updating the library-go to the commit: 3c53c54 so that it includes the code for network-policy
  2. Assests/*: This folder contains all the network policy required for the operand & the operator.
    • allow-egress-to-api-server-operand.yaml
    • allow-egress-to-api-server-operator.yaml
    • allow-ingress-to-metrics-operand.yaml
    • allow-ingress-to-metrics-operator.yaml
    • deny-all-namespace.yaml
  3. Updated CSV (ClusterServiceVersion) for including network policies in permissions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bertinatto and RomanBednar May 20, 2025 11:18
@PillaiManish PillaiManish force-pushed the network-policy-main branch from 146413d to 14503a7 Compare May 20, 2025 11:28
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 20, 2025 •
edited by openshift-ci bot
Loading

@PillaiManish: This pull request references SSCSI-104 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references SSCSI-105 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

This PR implements the Network Policy (OCPSTRAT-819) for the secrets-store-csi-driver operator and the operand.

File Changed:

  1. go.mod & vendor: Updating the library-go to the commit: 3c53c54 so that it includes the code for network-policy
  2. Assests/*: This folder contains all the network policy required for the operand & the operator.
    • allow-egress-to-api-server-operand.yaml
    • allow-egress-to-api-server-operator.yaml
    • allow-ingress-to-metrics-operand.yaml
    • allow-ingress-to-metrics-operator.yaml
    • deny-all-namespace.yaml
  3. Updated CSV (ClusterServiceVersion) for including network policies in permissions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@PillaiManish PillaiManish force-pushed the network-policy-main branch from 14503a7 to fbebc1e Compare May 20, 2025 13:40
arkadeepsen
arkadeepsen reviewed May 20, 2025
View reviewed changes
arkadeepsen
arkadeepsen reviewed May 20, 2025
View reviewed changes
arkadeepsen
arkadeepsen reviewed May 20, 2025
View reviewed changes
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 20, 2025 •
edited by openshift-ci bot
Loading

@PillaiManish: This pull request references SSCSI-104 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references SSCSI-105 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

This PR implements the Network Policy (OCPSTRAT-819) for the secrets-store-csi-driver operator and the operand.

File Changed:

  1. go.mod & vendor: Updating the library-go to the commit: 7de7fae so that it includes the code for network-policy
  2. Assests/*: This folder contains all the network policy required for the operand & the operator.
    • allow-egress-to-api-server-operand.yaml
    • allow-egress-to-api-server-operator.yaml
    • allow-ingress-to-metrics-operand.yaml
    • allow-ingress-to-metrics-operator.yaml
    • deny-all-namespace.yaml
  3. Updated CSV (ClusterServiceVersion) for including network policies in permissions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@PillaiManish PillaiManish force-pushed the network-policy-main branch 2 times, most recently from 57adf53 to f446bc9 Compare May 21, 2025 06:45
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 21, 2025 •
edited by openshift-ci bot
Loading

@PillaiManish: This pull request references SSCSI-104 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references SSCSI-105 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@PillaiManish
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 21, 2025 •
edited by openshift-ci bot
Loading

@PillaiManish: This pull request references SSCSI-104 which is a valid jira issue.

This pull request references SSCSI-105 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@PillaiManish PillaiManish force-pushed the network-policy-main branch from f446bc9 to a2a72b5 Compare May 21, 2025 10:05
@PillaiManish
Copy link
Contributor Author

/retest all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 21, 2025

@PillaiManish: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test ci-index-secrets-store-csi-driver-operator-bundle

/test fips-image-scan-mustgather

/test fips-image-scan-operator

/test images

/test operator-e2e-fips

/test unit

/test verify

/test verify-deps

The following commands are available to trigger optional jobs:

/test operator-e2e-vault-fips

/test security

Use /test all to run all jobs.

In response to this:

/retest all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@PillaiManish
Copy link
Contributor Author

/test all

@PillaiManish PillaiManish force-pushed the network-policy-main branch 2 times, most recently from c329947 to bb7cd03 Compare May 22, 2025 05:39
@arkadeepsen
Copy link
Member

Please fix the typo in the commit message of 9f38069. Also remove the empty files added as part of the commit.

@PillaiManish PillaiManish force-pushed the network-policy-main branch 2 times, most recently from dd98066 to d4d6f76 Compare May 22, 2025 07:17
@PillaiManish PillaiManish force-pushed the network-policy-main branch from d4d6f76 to c48951c Compare May 22, 2025 07:18
@PillaiManish PillaiManish force-pushed the network-policy-main branch from c48951c to 58320aa Compare May 26, 2025 04:41
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 26, 2025 •
edited by openshift-ci bot
Loading

@PillaiManish: This pull request references SSCSI-104 which is a valid jira issue.

This pull request references SSCSI-105 which is a valid jira issue.

In response to this:

This PR implements the Network Policy (OCPSTRAT-819) for the secrets-store-csi-driver operator and the operand.

File Changed:

  1. go.mod & vendor: Updating the library-go to the commit: 7de7fae so that it includes the code for network-policy
  2. Assests/*: This folder contains all the network policy required for the operand & the operator.
    • allow-egress-to-api-server-operand.yaml
    • allow-egress-to-api-server-operator.yaml
    • allow-ingress-to-metrics-operand.yaml
    • allow-ingress-to-metrics-operator.yaml
  3. Updated CSV (ClusterServiceVersion) for including network policies in permissions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@PillaiManish
Copy link
Contributor Author

/retest

1 similar comment
@PillaiManish
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 26, 2025

@PillaiManish: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@arkadeepsen
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2025
@arkadeepsen
Copy link
Member

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkadeepsen, PillaiManish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadeepsen arkadeepsen arkadeepsen left review comments

@bertinatto bertinatto Awaiting requested review from bertinatto

@RomanBednar RomanBednar Awaiting requested review from RomanBednar

Assignees

@arkadeepsen arkadeepsen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PillaiManish @openshift-ci-robot @arkadeepsen