Skip to content

NO-JIRA: replace react-router* with react-router-dom-v5-compat #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

zhuje
Copy link
Contributor

@zhuje zhuje commented Apr 15, 2025

Context

remove react-router and react-router-dom to be replaced by react-router-dom-compat-v5 for transition to react-router v6

Related JIRA from /openshift/console changes

openshift/console#14957

Threads

Slack #observability-ui-interal thread
https://redhat-internal.slack.com/archives/C03EPFR2BAR/p1744392852882399

Slack #announce-console-plugins
https://redhat-internal.slack.com/archives/C032NLNEE8G/p1744391666020899

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 15, 2025
@openshift-ci-robot
Copy link

@zhuje: This pull request explicitly references no jira issue.

In response to this:

Context

remove react-router and react-router-dom to be replaced by react-router-dom-compat-v5 for transition to react-router v6

Related JIRA from /openshift/console changes

openshift/console#14957

Threads

Slack #observability-ui-interal thread
https://redhat-internal.slack.com/archives/C03EPFR2BAR/p1744392852882399

Slack #announce-console-plugins
https://redhat-internal.slack.com/archives/C032NLNEE8G/p1744391666020899

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2025
Copy link
Contributor

@PeterYurkovich PeterYurkovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR needs to remove the old packages from the package.json and include the compat one

@zhuje zhuje force-pushed the react-router-compat branch from a288a01 to e155c2c Compare April 15, 2025 14:22
Copy link

openshift-ci bot commented Apr 15, 2025

@zhuje: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zhuje
Copy link
Contributor Author

zhuje commented Apr 15, 2025

In the latest push, I removed the old packages from the package.json and included the compat one

@etmurasaki
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 17, 2025
@PeterYurkovich
Copy link
Contributor

/lgtm

@PeterYurkovich
Copy link
Contributor

/label ux-approved
no ux changes

@openshift-ci openshift-ci bot added ux-approved Signifies that UX has signed off on this PR lgtm Indicates that a PR is ready to be merged. labels Apr 17, 2025
Copy link

openshift-ci bot commented Apr 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PeterYurkovich, zhuje

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [PeterYurkovich,zhuje]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5b4c066 into openshift:main Apr 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR ux-approved Signifies that UX has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants