-
Notifications
You must be signed in to change notification settings - Fork 9
NO-JIRA: replace react-router* with react-router-dom-v5-compat #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@zhuje: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR needs to remove the old packages from the package.json and include the compat one
…ct-router-dom Signed-off-by: Jenny Zhu <[email protected]>
a288a01
to
e155c2c
Compare
@zhuje: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
In the latest push, I removed the old packages from the package.json and included the compat one |
/label qe-approved |
/lgtm |
/label ux-approved |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PeterYurkovich, zhuje The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Context
remove react-router and react-router-dom to be replaced by react-router-dom-compat-v5 for transition to react-router v6
Related JIRA from /openshift/console changes
openshift/console#14957
Threads
Slack #observability-ui-interal thread
https://redhat-internal.slack.com/archives/C03EPFR2BAR/p1744392852882399
Slack #announce-console-plugins
https://redhat-internal.slack.com/archives/C032NLNEE8G/p1744391666020899