Remove ExponentialContactForce::Parameters subclass and add bindings support for ExponentialContactForce
#4228
+576
−464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
In some cases, SWIG struggles with creating bindings for classes with subclasses, and this is the case for
ExponentialContactForceon Windows builds. This change removes theExponentialContactForce::Parameterssubclass and moves all of the properties intoExponentialContactForce. Additionally,ExponentialContactForcehas been refactored to not exposeSimTK::ExponentialSpringParametersto the user, which should be more friendly to scripting users.A brief list of individual changes:
ExponentialContactForcefor each property. The getter methods return the value stored in the internalSimTK::ExponentialSpringParameters. The setter methods handle syncing the property value updates with the internal parameters.isPropertiesEqualandisParametersEqualtesting helper functions.testExponentialContact.cppto accommodate all above changes.Finally,
ExponentialContactForceis added to the bindings to provide access in Python/Matlab.Testing I've completed
Ran tests locally on MacOS (arm64).
Looking for feedback on...
CHANGELOG.md (choose one)
This change is