Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Finalized the implementation of
MeyerFregly2016Force, aForceelement equivalent to the contact model available in the Neuromusculoskeletal Modeling (NMSM) Pipeline. This model will enable generating simulations in the NMSM pipeline that are more tightly integrated into the OpenSim API and hopefully improve performance.In addition, the experimental classes.
AckermannVanDenBogert2010ForceandEspositoMiller2018Forcehas been removed, as they are not used in any Moco examples, advertised in the documentations, and there no plans to support these classes going forward. This means that the filesStationPlaneContactForce.h/.cpphave been removed, and the implementation ofMeyerFregly2016Forcehas been moved underOpenSim/Simulation/Model.A side effect of removing
StationPlaneContactForce.h/.cppis that the include structures of many files in Moco had to be update, sinceStationPlaneContactForceincludeosimSimulation, which was then included viaosimMoco. These changes reflect more of a "include what you use" style.Testing I've completed
Updated the testing for
MuscleFregly2016ForceintestMocoContact.cpp.Looking for feedback on...
CHANGELOG.md (choose one)
This change is