Open
Conversation
chia7712
reviewed
May 26, 2023
Contributor
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
@qoo332001 感謝實驗
中文的描述可以再多讀幾次，盡量精練和精準，這練習一下對自己寫論文也會有好處
docs/balancer/README.md
Outdated
|
|
||
| ## 成本估計 | ||
|
|
||
| * 成本估計實驗報告 |
docs/balancer/README.md
Outdated
|
|
||
| * 成本估計實驗報告 | ||
| * [磁碟空間限制實驗](experiment_brokerDiskSpace.md) : kafka partition的搬移過程中會產生一些成本，在搬移前先估計出搬移partition過程中可能佔用的broker/硬碟空間並對其做限制，確保搬移不會佔用過多的儲存空間 | ||
| * [搬移時間限制實驗](experiment_partitionMigrateTime.md) : kafka partition的搬移過程中會產生一些成本，在搬移前先估計出搬移partition過程中可能花費多少搬移時間，並對其做限制確保搬移不會花費過多的時間 |
Contributor
There was a problem hiding this comment.
確保搬移不會花費過多的時間 這句的描述也需要調整，我們無法保證不會花費“過多”的時間，只能保證不會超過使用者定義的時間上限
| 進行底層硬體效能資料的攝取。 | ||
|
|
||
| 您可以使用專案內的 | ||
| [./docker/start_node_exporter.sh](https://github.com/skiptests/astraea/blob/7596f590ae0f0ec370a6e257c10cc2aeb5fb5bf4/docs/run_node_exporter.md), |
Contributor
There was a problem hiding this comment.
這裡的縮寫可以直接說 node exporter 就好，剩下的就去參考連結中查看
| } | ||
| ], | ||
| "moveCosts": [ | ||
| "org.astraea.common.cost.PartitionMigrateTimeCost" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
此PR新增 #1665 的實驗報告