Fix incorrect recursion on Hostname via %h#76
Open
tb3088 wants to merge 5 commits intoopenssh:masterfrom
Open
Conversation
Contributor
|
This certainly makes sense to fix. But as you certainly read in the readme, OpenSSH team uses github only as a mirror and patches and bug reports should be sent to mailing list and bugzilla: https://www.openssh.com/list.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The %n token is defined as the original host value as specified on the command-line. It stands to reason that
hostname %his gratuitous and benign by virtue of being a NOOP,hostname %h.domainmakes no sense. Onlyhostname %n.domaincomplies with the documentation. Perhaps when %n was added to the list of tokens, nobody went back to update the code. Also ssh.c and readconf.c were not kept in sync despite the comment in both locations.Given the age of this defect, and the world-wide use of '%h' we may want to run both incarnations of percent_expand back to back so as to not break a billion configuration files.