Skip to content

NFV network config changes #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jaganathancse
Copy link
Contributor

This change is to remove ovs_bridge config for controlplane, intenal_api, storage and tenant configs and update based on linux_bond configs.

This change is to remove ovs_bridge config for controlplane,
intenal_api, storage and tenant configs and update based on
linux_bond configs.
@openshift-ci openshift-ci bot requested review from cjeanner and fultonj January 29, 2025 15:16
Copy link

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jaganathancse
Once this PR has been reviewed and has the lgtm label, please assign cjeanner for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6544d6f0332d409ab93413b66e36bb16

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-ovs-dpdk SUCCESS in 3m 34s
rhoso-architecture-validate-ovs-dpdk-sriov FAILURE in 3m 21s
✔️ rhoso-architecture-validate-sriov SUCCESS in 3m 49s

Copy link

openshift-ci bot commented Jan 29, 2025

@Jaganathancse: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 0872a5a link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d1554e62bd814e0e9f76af0a489144db

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-ovs-dpdk SUCCESS in 3m 33s
rhoso-architecture-validate-ovs-dpdk-sriov FAILURE in 4m 25s
✔️ rhoso-architecture-validate-sriov SUCCESS in 4m 40s

- type: ovs_bridge
name: {{ neutron_physical_bridge_name }}
mtu: {{ min_viable_mtu }}
- type: interface
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong YAML indentation

vlan_id: {{ lookup('vars', networks_lower[network] ~ '_vlan_id') }}
device: bond_api
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This vlan interface block also needs one outer level of indendation (left-shift)

@rdiazcam
Copy link
Contributor

rdiazcam commented Feb 6, 2025

Please note that the configuration is values.yaml is a kind of template, the real config is actually provided in ci-framework-jobs (and we are currently using ovs_user_bridge there.

@abays
Copy link
Contributor

abays commented Mar 10, 2025

@Jaganathancse Any update on this?

@fultonj
Copy link
Contributor

fultonj commented Mar 10, 2025

I labeled this as a work in progress since it's been inactive. Feel free to remove the label when you need it reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants