-
Notifications
You must be signed in to change notification settings - Fork 94
NFV network config changes #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
NFV network config changes #485
Conversation
This change is to remove ovs_bridge config for controlplane, intenal_api, storage and tenant configs and update based on linux_bond configs.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Jaganathancse The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6544d6f0332d409ab93413b66e36bb16 ✔️ noop SUCCESS in 0s |
@Jaganathancse: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d1554e62bd814e0e9f76af0a489144db ✔️ noop SUCCESS in 0s |
- type: ovs_bridge | ||
name: {{ neutron_physical_bridge_name }} | ||
mtu: {{ min_viable_mtu }} | ||
- type: interface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong YAML indentation
vlan_id: {{ lookup('vars', networks_lower[network] ~ '_vlan_id') }} | ||
device: bond_api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This vlan interface block also needs one outer level of indendation (left-shift)
Please note that the configuration is values.yaml is a kind of template, the real config is actually provided in ci-framework-jobs (and we are currently using |
@Jaganathancse Any update on this? |
I labeled this as a work in progress since it's been inactive. Feel free to remove the label when you need it reviewed. |
This change is to remove ovs_bridge config for controlplane, intenal_api, storage and tenant configs and update based on linux_bond configs.