[BGP] Set edpm_network_config_nmstate=false #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default value was changed to true (NM is used instead of ifcfg) with [1]. With the new default value, os-net-config fails on BGP setups. Related-Bug: OSPRH-17472 [1] openstack-k8s-operators/edpm-ansible#908
lmiccini
approved these changes
Jun 13, 2025
|
/approve |
ccamposr
approved these changes
Jun 13, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccamposr, eduolivares, fultonj, lmiccini The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
Build succeeded (gate pipeline). ✔️ noop SUCCESS in 0s |
softwarefactory-project-zuul
bot
merged commit 1ec7115
into
openstack-k8s-operators:main
7 checks passed
softwarefactory-project-zuul bot
added a commit
that referenced
this pull request
Jul 7, 2025
…-17472 Revert "[BGP] Set edpm_network_config_nmstate=false" Reverts #566 Revert reason: OSPRH-17472 has been resolved Reviewed-by: Andrew Bays <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default value was changed to true (NM is used instead of ifcfg) with [1].
With the new default value, os-net-config fails on BGP setups.
Related-Bug: OSPRH-17472
[1] openstack-k8s-operators/edpm-ansible#908