Skip to content

NFV OVS DPDK and SRIOV workload changes #2606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NFV OVS DPDK and SRIOV workload changes #2606

wants to merge 1 commit into from

Conversation

Jaganathancse
Copy link

This change is to add workload with both ovs dpdk
and sriov ports and ping testing for both ports
during update.

@github-actions GitHub Actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@github-actions github-actions bot marked this pull request as draft December 16, 2024 06:12
@Jaganathancse Jaganathancse force-pushed the nfv_workload_sriov_dpdk_both branch 2 times, most recently from 5400111 to 79e2a0a Compare December 16, 2024 06:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 1, 2025

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 1, 2025
@github-actions github-actions bot closed this Jan 9, 2025
@Jaganathancse Jaganathancse reopened this Jan 9, 2025
@Jaganathancse Jaganathancse force-pushed the nfv_workload_sriov_dpdk_both branch from 79e2a0a to 4b9addb Compare January 9, 2025 10:20
@github-actions github-actions bot removed the Stale label Jan 10, 2025
@github-actions GitHub Actions
Copy link

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 26, 2025
@github-actions github-actions bot closed this Feb 3, 2025
@Jaganathancse Jaganathancse reopened this Feb 3, 2025
@github-actions github-actions bot removed the Stale label Feb 4, 2025
@github-actions GitHub Actions
Copy link

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 19, 2025
@github-actions github-actions bot closed this Feb 26, 2025
@Jaganathancse
Copy link
Author

planning to update this Pr.

@Jaganathancse Jaganathancse reopened this Feb 26, 2025
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4bcf143c69bf47a8b1278a106ce677ac

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 34m 11s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 12s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 13m 19s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 22s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 37s
✔️ build-push-container-cifmw-client SUCCESS in 18m 34s
✔️ cifmw-molecule-update SUCCESS in 6m 48s

@github-actions github-actions bot removed the Stale label Feb 27, 2025
@Jaganathancse Jaganathancse force-pushed the nfv_workload_sriov_dpdk_both branch from 4b9addb to 32cba42 Compare March 10, 2025 05:23
@Jaganathancse Jaganathancse force-pushed the nfv_workload_sriov_dpdk_both branch from dfaaca7 to 6d70e36 Compare March 24, 2025 04:04
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2025

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 9, 2025
NFV OVS DPDK and SRIOV workload changes
23d159f 
This change is to add workload with both ovs dpdk
and sriov ports and ping testing for both ports
during update.
@Jaganathancse Jaganathancse force-pushed the nfv_workload_sriov_dpdk_both branch from 6d70e36 to 23d159f Compare April 9, 2025 03:43
@Jaganathancse Jaganathancse marked this pull request as ready for review April 9, 2025 03:45
@Jaganathancse Jaganathancse requested a review from a team as a code owner April 9, 2025 03:46
@Jaganathancse
Copy link
Author

recheck

danpawlik
danpawlik reviewed Apr 22, 2025
View reviewed changes
roles/update/templates/workload_launch.sh.j2
@@ -510,7 +542,16 @@ if [[ "${MODE}" == "workload_traffic" ]]; then
echo "export CINDER_VOL_ID=${CINDER_VOL_ID}" >> ~/workload_suffix
echo "export INSTANCE_FIP=${INSTANCE_FIP}" >> ~/workload_suffix
echo "export VM_IP=${VM_IP}" > ~/vm_ip.sh
generate_traffic
local workload_sriov={{workload_sriov|default(false) | bool | ternary("True", "")}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just:

    local workload_sriov={{workload_sriov|default(false) | bool  }}
    local workload_dpdk={{workload_dpdk|default(false) | bool }}

danpawlik
danpawlik reviewed Apr 22, 2025
View reviewed changes
roles/update/templates/workload_launch.sh.j2
@@ -42,8 +42,8 @@ function os_cmd {

function set_vm_ip {
## assign floating ip or external ip
local workload_sriov={{workload_sriov|default(false) | bool | ternary("True", "")}}
if [ -n "${workload_sriov}" ]; then
local fixed_ip={{ $1|default(false) | bool }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how it should work? Here I see bash + ansible in jinja2 template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danpawlik danpawlik danpawlik left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jaganathancse @danpawlik