Prevent updating openstackclient pod during openstack update #2880
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ba32d2954f7041bb9464f261360a800c ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 52m 46s |
ciecierski
force-pushed
the
openstackclient-update
branch
from
c0ef425 to
5b61488
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8dcbc2ecdff24762840fec20d5ec23ad ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 45m 50s |
ciecierski
force-pushed
the
openstackclient-update
branch
from
5b61488 to
02924d1
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b506c1dd579643d1b69456fb6bb0d06e ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 36m 25s |
ciecierski
force-pushed
the
openstackclient-update
branch
2 times, most recently
from
ed86dd0 to
2547e11
Compare
Openstackclient pod is used during update to start/stop continues workload tests from it. Openstackclient should not be updated during update to not interfere with this tests. Update of the client should happend at the end of update on request.
ciecierski
force-pushed
the
openstackclient-update
branch
from
2547e11 to
d340c44
Compare
| ansible.builtin.command: | | ||
| {{ cifmw_update_artifacts_basedir }}/control_plane_test_stop.sh | ||
|
|
||
| - name: Patch openstackversion to trigger update of openstackclient |
There was a problem hiding this comment.
nit: maybe Patch openstackversion to ensure openstackclient version is right
|
As far as I understand this end up not working because the pod was still restarted even if its image was not changed. here I gave a try to this in another way: create a container with all the required file to authenticate against openstack and run it using podman on the controller. So far this was successful. |
Pod is restarted only during openstack-init file creation, but not during openstack minor update. During openstack minor update it waits until update completes and then update is triggered by removing customImage from openstack version CR. As a 3rd alternative option is to instal python-openstackclient on host, get credentials from pod running in OpenShift and use it to run commands. |
|
Decoupling the continuous testing logic from the openstackclient pod sounds a bit better to me than doing special handling with the pod in the testing workflow. (The special handling complicates the workflow in a way that doesn't stem from user needs, rather it stems just from testing choices. Also if we don't propagate the more complex workflow into the docs, the distance between what's documented and what's tested increases.) |
Openstackclient pod is used during update to start/stop continues workload tests from it. Openstackclient should not be updated during update to not interfere with this tests. Update of the client should happen at the end of update on request.