Update CRDs when changing test-operator version #2906
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This patch introduces the ExtraMounts parameter to test-operator. The purpose is to be able to specify PersistentVolumeClaim, Secret, ConfigMap and mount it to the test pod spawned by the test-operator. Depends-On: openstack-k8s-operators/ci-framework#2906
kstrenkova
force-pushed
the
update-crds-test-operator
branch
5 times, most recently
from
6988524 to
42ba261
Compare
Currently, the merging of workflow section is done in controllers of related CRs. We want to move the merging logic into webhooks to make the process cleaner. Depends-On: openstack-k8s-operators/ci-framework#2906
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3c5156019430415a96401a983b2ccd25 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 46m 51s |
Currently, the merging of workflow section is done in controllers of related CRs. We want to move the merging logic into webhooks to make the process cleaner. Depends-On: openstack-k8s-operators/ci-framework#2906
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/36d26c9520f34ae6b18c742178de679b ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 37s |
kstrenkova
force-pushed
the
update-crds-test-operator
branch
from
755ccda to
34c4d58
Compare
This patch introduces the ExtraMounts parameter to test-operator. The purpose is to be able to specify PersistentVolumeClaim, Secret, ConfigMap and mount it to the test pod spawned by the test-operator. Depends-On: openstack-k8s-operators/ci-framework#2906
|
/retest |
kstrenkova
force-pushed
the
update-crds-test-operator
branch
from
34c4d58 to
31dfaf5
Compare
kstrenkova
force-pushed
the
update-crds-test-operator
branch
from
31dfaf5 to
5ce1eeb
Compare
This patch introduces the ExtraMounts parameter to test-operator. The purpose is to be able to specify PersistentVolumeClaim, Secret, ConfigMap and mount it to the test pod spawned by the test-operator. Depends-On: openstack-k8s-operators/ci-framework#2906
Currently, the merging of workflow section is done in controllers of related CRs. We want to move the merging logic into webhooks to make the process cleaner. Depends-On: openstack-k8s-operators/ci-framework#2906
kstrenkova
force-pushed
the
update-crds-test-operator
branch
from
5ce1eeb to
b592981
Compare
Currently, the merging of workflow section is done in controllers of related CRs. We want to move the merging logic into webhooks to make the process cleaner. Depends-On: openstack-k8s-operators/ci-framework#2906
This patch updated the CRDs, if the user wants to patch the test operator version. Until now the CRDs stayed unchanged even after version change, so testing new test-operator parameters was not possible. It is important to point out, that the update will not be triggered in 90% of test-operator use cases. It is primarily used in two situations: 1. When running checks for new PRs in the test-operator repository. 2. When updating the test-operator version in jobs to prevent failures. The approach isn’t the cleanest, but alternative solutions are significantly more complex than the benefits they offer.
kstrenkova
force-pushed
the
update-crds-test-operator
branch
from
b592981 to
645a2c4
Compare
| - "{{ cifmw_test_operator_ansibletest_crd_name }}" | ||
| - "{{ cifmw_test_operator_horizontest_crd_name }}" | ||
|
|
||
| - name: Clone test-operator repository and checkout into specified version |
There was a problem hiding this comment.
I'm wondering, how are we getting the test-operator at the first place. Is it shipped as the github repository? Or is it downloaded from the image hub?
This is very risky. Every time when the new change is introduced to the main branch, we might end up with overwriting existing tests. It allows for faster iteration, but it's not safe.
This patch updates the CRDs, if the user wants to patch the test operator version. Until now the CRDs stayed unchanged even after version change, so testing new test-operator parameters was not possible. It is important to point out, that the update will not be triggered in 90% of test-operator use cases. It is primarily used in two situations:
The approach isn’t the cleanest, but alternative solutions are significantly more complex than the benefits they offer.