DNM: Use $PIP instead of explicit $SYSTEM_PIP #2907
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c6df55d6647445d280386661c600e604 ✔️ openstack-k8s-operators-content-provider SUCCESS in 38m 25s |
|
Closing this for now, as this change should be one of the last steps. Investigating how we can do that. Closing it for now. |
amartyasinha
changed the title
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a571fc25cdea4f2db7d73f8832705c94 ✔️ openstack-k8s-operators-content-provider SUCCESS in 34m 58s |
…explicit $SYSTEM_PIP This patch is the first step in enforcing the use of venv for cifmw. We want that all deps of cifmw should be within it's venv and should not consume system's pip.
need to investigate
amartyasinha
force-pushed
the
use-pip-in-venv
branch
from
7f8aa1a to
a64868c
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b9122edaafc54a649664eb0a1b7a1b51 ❌ openstack-k8s-operators-content-provider FAILURE in 12m 45s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c6750bd2e6b24e83ae47d0390c7e3a52 ❌ openstack-k8s-operators-content-provider FAILURE in 12m 32s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/cd204735d6454fc1a1a9ce0e620ace66 ✔️ openstack-k8s-operators-content-provider SUCCESS in 36m 42s |
It may be possible that since we are not setting up USE_VENV to yes, it's consuming system env. This commit is just to test it.
It may be possible that zuul is not loading HOME var value. This commit is just to test it by explicitly setting it's value.
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e45446f88a514e48b85bff206d88e7e5 ✔️ openstack-k8s-operators-content-provider SUCCESS in 36m 17s |
…nv within the shell
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6735ef02e8eb43119e2990169f9cbd4e ✔️ openstack-k8s-operators-content-provider SUCCESS in 45m 20s |
Even if ansible-playbook is consuming venv, but ansible_python_interpreter is set to auto, it will depend on system to setup that, and that's why the modules were consuming /usr/bin/python3 instead of venv python. This patch should fix it.
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/50bf6139cfed44148342ee1f45e4c0f4 ✔️ openstack-k8s-operators-content-provider SUCCESS in 36m 28s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ade752aee7f445c7834d539972a4327a ❌ openstack-k8s-operators-content-provider RETRY_LIMIT in 2m 39s |
amartyasinha
force-pushed
the
use-pip-in-venv
branch
from
3d7edfd to
a838410
Compare
libvirt package has host OS bindings, thus installing within venv is pain. Ref: ansible-collections/community.libvirt#71 (comment) Thus, installing through distribution package (dnf), and including in venv through --system-site-packages
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6204cb672bdc407ea4a0e355c881440e ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 48m 09s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a5e8fb74c1a34f2fbfa3ee9d0fd7d7a3 ✔️ openstack-k8s-operators-content-provider SUCCESS in 38m 39s |
Instead of setting this var during runtime, it is better to set it up in config file.
amartyasinha
force-pushed
the
use-pip-in-venv
branch
from
ae79e54 to
53c1be4
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/76c183198c5641ea8bc0ce3bfef9858e ❌ openstack-k8s-operators-content-provider FAILURE in 4m 17s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/161e5090f4624c5d81fae38f86e5d172 ❌ openstack-k8s-operators-content-provider FAILURE in 4m 16s |
in order to use venv python, we may want to ensure that interpreter_python is set to the venv's python whenever it exists
|
recheck |
This patch is the first step in enforcing the use of venv for cifmw. We want that all deps of cifmw should be within it's venv and should not consume system's pip.
It is important as from python3.12 onwards, use of system wide packages are discouraged, and it is recommended to use venv.
Ref: https://issues.redhat.com/browse/OSPRH-15882