Add conditional for use CentOS nodepool mirror #2927
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/84bf68bacfc342bfb8e2855ec4070bd6 ❌ openstack-k8s-operators-content-provider FAILURE in 4m 40s |
rlandy
force-pushed
the
ci-mirror-centos
branch
3 times, most recently
from
f1870d2 to
cda4937
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4c588d64633044f186286b16b22df309 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 32m 56s |
rlandy
force-pushed
the
ci-mirror-centos
branch
8 times, most recently
from
4b00b74 to
faa38d5
Compare
rlandy
force-pushed
the
ci-mirror-centos
branch
from
faa38d5 to
dbe9b5a
Compare
|
Is it for review? |
yes, it is good to go! |
|
/lgtm |
| @@ -12,6 +12,8 @@ | |||
| set -o pipefail | |||
| source /etc/ci/mirror_info.sh | |||
| sed -i -e "s|https://trunk.rdoproject.org|$NODEPOOL_RDO_PROXY|g" *.repo | |||
| {% if ansible_distribution | lower == 'centos' and ansible_distribution_major_version is not version('10', '==') %} | |||
There was a problem hiding this comment.
Can you add additional info about location of CentOS10 nodepool? If it doesn't exist, please create another when condition. Instead of nesting if/else here, please modify the line 10, and extend it over there. For the Centos10 specific use-case, please add another task.
You might consider using nested conditions, something like:
- block
- name: cs9
when: major_version is < 10
- name: cs10
when: major_version is 10
when:
- mirror_path.stat.exists
No description provided.