Sync Olive #2946
Open
Sync Olive #2946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzyfriday
requested review from
bshephar,
drosenfe,
a team,
fultonj,
fmount,
abays,
hjensas,
rlobillo and
eurijon
as code owners
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR#2839 introduced an issue where pre and post hooks are executed multiple times. Let's revert the loop on pre/post hook execution to restore the previous behaviour. I belive a `stage.name` can still be used for `cifmw_architecture_user_kustomize` after this revert.
…es role" This is breaking builds with downstream driver in two ways: - Not using --local requires the repos to have proper remote definition. - pre-run scripts as patch_rebaser [1] also require proper remotes. For the first, we may handle it via change in dlrn [2], but for the second one I'm not sure about the best way. [1] https://github.com/release-depot/patch_rebaser/ [2] https://softwarefactory-project.io/r/c/DLRN/+/33366 This reverts commit f79ca6f.
After reverting [1] we still have problems when building multiple in-flight patches in any form: 1. Having multiple depends-on on the same package does not work. 2. Piling multiple reviews and adding the depends-on to the top one is also not working. This patch is reversing the order of the related zuul changes to fix the case (2) as it will find and process the top change for the repo.
This PR exposes the extraMounts parameter for all test-operator related CRs (Tempest, Tobiko, AnsibleTest, HorizonTest). This parameter can be used to specify additional volume mounts for the test pods spawned by test-operator.
In build_openstack_packages role for building rpms from gerrit and github, we are clonning the repo and checking out specific change. With these tasks, we are not able to build dlrn rpms if we have multiple prs/crs from same project. But we want to build rpms from all changes. In order to fix, Zuul knows how to checkout proper repos with changes under test and from Depends-on. DLRN always looks for clonned repos in DLRN data directory. In order to use zuul clonned sources with DLRN, We are creating symlink to dlrn data project directory and let's dlrn do the job for upstream repos only. Note: we reverted the similar pr[1] here as original change was lacking proper condition[2] leading to breaking downstream build openstack packages role. By adding proper conditional for upstream, it fixes the issue. Links: [1]. openstack-k8s-operators#2818 [2]. openstack-k8s-operators@f79ca6f#diff-fedeaff036de20345e170c4f65374926975f17139c058369f2e909565054e1adR118-L134 Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
The aim is to enable risky-file-permissions linter.
According to object patching failure spec.cleanup in body must be of type boolean. Cast var to bool type.
This reverts commit 63d1635. Revert "Enable risky-file-permissions linter" This reverts commit c50dea3. These commits broke the package builds in content provider jobs with:- Failed to get information on remote file (/home/zuul/ci-framework-data/artifacts/repositories/gating.repo): Permission denied Related-Issue: OSPRH-15047
Allowed cleaning up deployment resources as well as operators.
The script was not providing stats properly, because the oc binary is located in different place. Signed-off-by: Daniel Pawlik <[email protected]>
Multiple job definitions with the same name are called variants. These may have different selection criteria which indicate to Zuul that, for instance, the job should behave differently on a different git branch. In this case, we have the same jobs, doing almost the same thing. Removed duplicated job definition.
To allow for virtualenv usage, force the script to search for python set in an environment variable. By avoiding hard-coding, we don't need to modify system-wide requirements.
During apply_mask, there is a possibility that our key in yaml_dict is of other data type (bool or int). In such cases, re.findall will fail as it expects string. Due to this, key is typecast to str to avoid this runtime error
Since we are now handling boolean keys too, added a data with boolean key for testing
Since we are now handling other data type keys too, added data's with int and float key to process_list
Using vars will help in overriding the spec as per the requirement during adoptoin. Also count:1 will create issues as ingress handles both haproxy and keepalived
The hardcoded value for controller default network interface is making problems on local deployment of kuttl job. With that patch, few steps would be less to execute. Signed-off-by: Daniel Pawlik <[email protected]>
We don't test RGW multisite in OpenStack. From squid+ a default realm is not deployed anymore, resulting in RGW deployment failures. This patch removes both default realm and zone from the RGW spec. Signed-off-by: Francesco Pantano <[email protected]>
Add a validator that verifies a faulty bmh compute node may be replaced
When Ansible is executed in verbose mode, the oc completion output is not needed to print. Signed-off-by: Daniel Pawlik <[email protected]>
Set the correct hostname (without the extra prefix "edpm-"). The hostname of the compute nodes is set to a name without the "edpm-" prefix by ci-fmw when the VMs are provisioned. Once the dataplane is deployed with a different hostname which would be configured in the OCP DNS used by dataplane nodes (after dataplane deployed) The original hostname which is still set on the dataplane nodes would not be recognized by the DNS and the correct domain would not be used. Instead the original domain which was set by DHCP during the VM nodes provisioning by ci-framework would be set until the DHCP lease is lost and that eventually leads to fqdn of dataplane nodes mismatch
Zuul accept list or string as a value for pre-run and post-run. During a process of building jobs, Zuul combines pre/post-runs into lists. To avoid confusions, convert values into lists. https://zuul-ci.org/docs/zuul/latest/config/job.html#attr-job.pre-run https://zuul-ci.org/docs/zuul/latest/config/job.html#attr-job.post-run
The yaml callback plugin is deprecated [1] and it has been replaced by ansible.builtin.default. Also enable callback_format_pretty to yaml that is more easy to read comparing to json. [1] https://docs.ansible.com/ansible/latest/collections/community/general/yaml_callback.html Signed-off-by: Daniel Pawlik <[email protected]>
The spellcheck is failing due to missing words.
Decouple rdo-jobs from cifmw-molecule
amartyasinha
approved these changes
May 5, 2025
evallesp
approved these changes
May 5, 2025
bshewale
approved these changes
May 5, 2025
danpawlik
approved these changes
May 5, 2025
dasm
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.