Skip to content

Conversation

@lkuchlan
Copy link
Contributor

Ensure the primary cluster includes the required Ceph client configuration to access the secondary cluster. This is necessary for successful RBD mirroring operations.

Ensure the primary cluster includes the required Ceph client
configuration to access the secondary cluster. This is necessary
for successful RBD mirroring operations.
@lkuchlan lkuchlan requested a review from a team as a code owner August 18, 2025 16:24
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@danpawlik danpawlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you share link to job which is verifying it?

@lkuchlan
Copy link
Contributor Author

LGTM, but could you share link to job which is verifying it?

Sorry, I forgot to mark this PR as WIP
It still requires some additional changes

Copy link
Contributor

@danpawlik danpawlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should set this PR as draft, to avoid additional review. Thanks

@lkuchlan lkuchlan marked this pull request as draft August 31, 2025 06:44
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2025

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0145c42c03654b4eac19c654cf2c9ade

openstack-k8s-operators-content-provider TIMED_OUT in 31m 12s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 09s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 48s
✔️ build-push-container-cifmw-client SUCCESS in 17m 57s

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/87377433703b4e77aac8549d17227793

openstack-k8s-operators-content-provider TIMED_OUT in 31m 48s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 33s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 14s
✔️ build-push-container-cifmw-client SUCCESS in 48m 47s

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/dfe299445c1e4825a8131984e304be39

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 40m 45s
podified-multinode-edpm-deployment-crc RETRY_LIMIT in 13m 23s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 26m 20s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 31s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 11s
✔️ build-push-container-cifmw-client SUCCESS in 16m 20s

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/037d044afe084b3383d8cabf42b39fc7

openstack-k8s-operators-content-provider TIMED_OUT in 31m 10s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 16s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 00s
✔️ build-push-container-cifmw-client SUCCESS in 15m 46s

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bdedd2f12835458f8e2ff56f4b45e011

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 11s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 18m 46s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 28m 01s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 34s
cifmw-pod-pre-commit FAILURE in 7m 30s
✔️ build-push-container-cifmw-client SUCCESS in 18m 53s

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a82f339afb8e41a4be2491b4c9c45780

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 25s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 24m 19s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 20m 59s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 59s
cifmw-pod-pre-commit FAILURE in 7m 34s
✔️ build-push-container-cifmw-client SUCCESS in 16m 20s

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2b1b1a018ec34bdcba40a3812ce8b77e

openstack-k8s-operators-content-provider POST_FAILURE in 2h 05m 15s
podified-multinode-edpm-deployment-crc POST_FAILURE in 1h 17m 55s
cifmw-crc-podified-edpm-baremetal POST_FAILURE in 1h 19m 55s
✔️ noop SUCCESS in 0s
cifmw-pod-ansible-test POST_FAILURE in 8m 51s
cifmw-pod-pre-commit POST_FAILURE in 7m 26s
build-push-container-cifmw-client POST_FAILURE in 18m 27s

@fmount
Copy link
Contributor

fmount commented Sep 29, 2025

recheck

fmount
fmount previously approved these changes Sep 29, 2025
Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm


# File permissions and ownership
conf_file_mode: "{{ cifmw_replication_conf_file_mode | default('0644') }}"
keyring_file_mode: "{{ cifmw_replication_keyring_file_mode | default('0600') }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps we could merge L60 (keyring_file_mode) and L61 (token_file_mode) in a single variable, but I'm good if you think that is better to have a distiction between the two.

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a55ae0e2f3ac4319a864a7f2521f7cab

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 37s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 18m 08s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 26m 36s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 29s
cifmw-pod-pre-commit FAILURE in 7m 59s
✔️ build-push-container-cifmw-client SUCCESS in 19m 24s

@openshift-ci openshift-ci bot removed the lgtm label Oct 5, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2025

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@evallesp
Copy link
Contributor

evallesp commented Oct 6, 2025

LGTM but is there any testproject result?

@softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3976f3f1e9204bff9f4e1050c8981a1e

openstack-k8s-operators-content-provider FAILURE in 14m 07s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 32s
cifmw-pod-pre-commit FAILURE in 7m 31s
✔️ build-push-container-cifmw-client SUCCESS in 16m 43s

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a6099c946aad44ebbe7dce79c33d4056

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 41m 02s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 18m 42s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 25m 20s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 24s
cifmw-pod-pre-commit FAILURE in 7m 39s
✔️ build-push-container-cifmw-client SUCCESS in 19m 49s

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5ede0788cab94e3aa78118256a5f09c8

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 38m 28s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 06s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 24m 36s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 20s
cifmw-pod-pre-commit FAILURE in 7m 53s
✔️ build-push-container-cifmw-client SUCCESS in 18m 44s

Ensure the primary cluster includes the required Ceph client
configuration to access the secondary cluster.
This is necessary for successful RBD mirroring operations.
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bea0be1892e64dc3b7885dfe03baf13a

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 37m 46s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 01s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 22m 56s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 17s
cifmw-pod-pre-commit FAILURE in 7m 37s
✔️ build-push-container-cifmw-client SUCCESS in 19m 31s

@evallesp
Copy link
Contributor

Hi, you can run pre-commit by:

make run_ctx_pre_commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants