-
Notifications
You must be signed in to change notification settings - Fork 138
[cinder] Add Ceph client config for RBD mirroring #3199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Ensure the primary cluster includes the required Ceph client configuration to access the secondary cluster. This is necessary for successful RBD mirroring operations.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but could you share link to job which is verifying it?
Sorry, I forgot to mark this PR as WIP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should set this PR as draft, to avoid additional review. Thanks
|
Adding label Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0145c42c03654b4eac19c654cf2c9ade ❌ openstack-k8s-operators-content-provider TIMED_OUT in 31m 12s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/87377433703b4e77aac8549d17227793 ❌ openstack-k8s-operators-content-provider TIMED_OUT in 31m 48s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/dfe299445c1e4825a8131984e304be39 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 40m 45s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/037d044afe084b3383d8cabf42b39fc7 ❌ openstack-k8s-operators-content-provider TIMED_OUT in 31m 10s |
dc238bd to
788e2b5
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bdedd2f12835458f8e2ff56f4b45e011 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 11s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a82f339afb8e41a4be2491b4c9c45780 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 25s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2b1b1a018ec34bdcba40a3812ce8b77e ❌ openstack-k8s-operators-content-provider POST_FAILURE in 2h 05m 15s |
|
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
|
||
| # File permissions and ownership | ||
| conf_file_mode: "{{ cifmw_replication_conf_file_mode | default('0644') }}" | ||
| keyring_file_mode: "{{ cifmw_replication_keyring_file_mode | default('0600') }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps we could merge L60 (keyring_file_mode) and L61 (token_file_mode) in a single variable, but I'm good if you think that is better to have a distiction between the two.
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a55ae0e2f3ac4319a864a7f2521f7cab ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 37s |
|
New changes are detected. LGTM label has been removed. |
|
Adding label Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
LGTM but is there any testproject result? |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3976f3f1e9204bff9f4e1050c8981a1e ❌ openstack-k8s-operators-content-provider FAILURE in 14m 07s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a6099c946aad44ebbe7dce79c33d4056 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 41m 02s |
f6867ef to
c527321
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5ede0788cab94e3aa78118256a5f09c8 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 38m 28s |
Ensure the primary cluster includes the required Ceph client configuration to access the secondary cluster. This is necessary for successful RBD mirroring operations.
44d01a6 to
ca59df5
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bea0be1892e64dc3b7885dfe03baf13a ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 37m 46s |
|
Hi, you can run pre-commit by: |
Ensure the primary cluster includes the required Ceph client configuration to access the secondary cluster. This is necessary for successful RBD mirroring operations.