-
Notifications
You must be signed in to change notification settings - Fork 138
Add Barbican adoption support with Proteccio HSM integration #3351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Barbican adoption support with Proteccio HSM integration #3351
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3b6bfc9
to
9b443d6
Compare
18d1c05
to
fc89b9d
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/81e9957f54724f2289b84ba87dfc1d5c ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 46m 11s |
2c3efaf
to
67f4fe0
Compare
Implements comprehensive Barbican service adoption from OSP 17.1 to RHOSO 18 with optional Proteccio Hardware Security Module (HSM) integration. Features: - Base scenario for Barbican adoption without HSM (barbican.yaml) - Extended scenario with Proteccio HSM support (barbican-proteccio.yaml) - OSP 17.1 HSM configuration hook (barbican-osp17-proteccio-setup.yml) - Conditional HSM environment file inclusion in adoption workflow Implements: OSPRH-18874 Signed-off-by: Mauricio Harley <[email protected]>
67f4fe0
to
f510dd4
Compare
delegate_to: "osp-undercloud-0" | ||
ansible.builtin.copy: | ||
mode: '0644' | ||
dest: "{{ ansible_user_dir }}/enable-barbican-proteccio.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does the framework know to use the file in doing the 17.1 deployment?
I see in your rdo-jobs patch, you key off of file name - though actually you appear to be looking for something called proteccio-heat-vars.yaml in that patch.
I think ultimately you are probably going to want to set some generic parameter extra_tripleo_template or somesuch - and set that to the filename here.
Or you could create a directory {{ansible_user_dir}}/extra-heat-templates or some such and include the file there - and modify the rdo-jobs to read all files in that directory and add to the THT deploy command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclear yet as to which of these changes will be needed. The playbook will definitely be needed, but not sure about the rest.
Implements comprehensive Barbican service adoption from OSP 17.1 to RHOSO 18 while preserving Proteccio Hardware Security Module (HSM) integration. This extends the existing ci-framework adoption infrastructure rather than creating separate components.
Implements: OSPRH-18874