feat(/home/zuul): Replace /home/zuulpath Root and playbooks files #3396
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
reproducer and dcn tested at: https://issues.redhat.com/browse/OSPRH-19989 |
|
Tested deploy-edpm-reuse change by executing that manually in an already deployed environment. It calculates properly $HOME. |
| delegate_to: controller-0 | ||
| ansible.builtin.command: | ||
| cmd: "/home/zuul/cleanup-architecture.sh" | ||
| cmd: "$HOME/cleanup-architecture.sh" |
There was a problem hiding this comment.
why not {{ ansible_user_dir }}?
Same for others
There was a problem hiding this comment.
Because this task is delegated, so we should be fine with various host users.
There was a problem hiding this comment.
in that case, maybe "{{ lookup('env', 'HOME') }}" ?
There was a problem hiding this comment.
AFAIK command would expand env vars, but it's safer bet to move to your suggestion!
There was a problem hiding this comment.
It seems lookup is executed in the ansible control node, so if user differs between delegated host and control host, then we have a problem. I'm mantaining to $HOME
We're moving /home/zuul hardcoded paths from root-level files and ocurrences in files at playbook folder.
evallesp
force-pushed
the
update-cifmw-playbooks-root-home-zuul-vars
branch
from
ae5c4ed to
62453d9
Compare
2 participants
We're moving /home/zuul hardcoded paths from root-level files and ocurrences in files at playbook folder.