Add OIDC authentication flows tests for federation #3575
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
xek
force-pushed
the
oidc-auth-tests
branch
2 times, most recently
from
c2c5b11 to
133a0b4
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6784616a5ea14ec68f0010c05d3dfdeb ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 36m 26s |
This adds support for testing all OIDC authentication methods: - v3oidcpassword (Resource Owner Password Credentials) - v3oidcclientcredentials (Client Credentials) - v3oidcaccesstoken (Access Token Reuse) - v3oidcauthcode (Authorization Code) Note: v3oidcdeviceauthz requires Python 3.10+ and is not available in OSP18 which ships with Python 3.9.
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/888f51a660624496a38dbb9ea0ba7425 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 35m 57s |
jagee
left a comment
jagee
left a comment
There was a problem hiding this comment.
Everything looks good to me, just wanted see if you though we should remove one duplicate auth test from the older code.
| - "{{ cifmw_federation_keycloak_testuser1_username }}" | ||
| - "{{ cifmw_federation_keycloak_testuser2_username }}" | ||
| when: not cifmw_federation_deploy_multirealm|bool | ||
|
|
There was a problem hiding this comment.
What do you think about us eliminating the above section 69-80? since the run_openstack_oidc_auth_tests.yml is covering the "[v3oidcpassword] Get token for test user 1" task we are doing some duplication here and it might make more since to just have one round of this test in the new yaml. the only thing we are not doing is testing user2 but i dont think that is really important as they are both in the same project.
There was a problem hiding this comment.
the second test user is in there more for the horizon gui testing in the other dfgs testing.
2 participants
This adds support for testing all OIDC authentication methods:
New features:
Note: v3oidcdeviceauthz requires Python 3.10+ and is not
available in OSP18 which ships with Python 3.9.