[os_must_gather] Add exit rc to os-must-gather main task#3643
[os_must_gather] Add exit rc to os-must-gather main task#3643evallesp wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/13b13b3cca114b689ce68b1c964b9265 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 25m 06s |
evallesp
force-pushed
the
os-must-gather-return-error
branch
from
38aa2f1 to
9556cac
Compare
roles/os_must_gather/tasks/main.yml
Outdated
| --timeout {{ cifmw_os_must_gather_timeout }} | ||
| --volume-percentage={{ cifmw_os_must_gather_volume_percentage }} | ||
|
|
||
| - name: Create oc_inspect log directory |
There was a problem hiding this comment.
TBH, I don't see profit from this task and one below, but if you want, I can live with it.
There was a problem hiding this comment.
indeed, removed.
I've udpated the file to move the top commands in the always block. Just after checking the latest fodler is created.
With this we allow to run the rescue block. Previously any timeout in the main task would return the code from the echo which was always success. Also, we're removing from the rescue block the always block. And we've create a always section for finding existing os-must-gather directories and the symlink creation. Also we've changed the dest-dir for the generic fallback command to match the same folder of the symlink. Removed oc inspect as we're not getting so many errors from oc adm must-gather so probably this wouldn't be usefull. Finally, we've parametriced SOS_EDPM as cifmw_os_must_gather_sos_edpm and we've added default value to "all" Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
evallesp
force-pushed
the
os-must-gather-return-error
branch
from
9556cac to
a16e6d7
Compare
|
New changes are detected. LGTM label has been removed. |
|
I'm going to run a TP. |
|
/hold |
|
Probably need to hold for rebasing when https://github.com/openstack-k8s-operators/ci-framework/pull/3694/changes is merged |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f4bebabaa9da4f8784a72883ccbe7f5b ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 12m 10s |
3 participants
With this we allow to run the rescue block. Previously any timeout in the main task would return the code from the echo which was always success.
Also, we're removing from the rescue block the always block. And we've create a always section for finding existing os-must-gather directories and the symlink creation.
Also we've changed the dest-dir for the generic fallback command to match the same folder of the symlink.
Finally, we've parametriced SOS_EDPM as cifmw_os_must_gather_sos_edpm and we've added default value to "all"