Skip to content

Comments

Expose ansibleGitBranch (in test_operator ansibletest config) via cifmw variable#3698

Open
gmarcian wants to merge 2 commits intoopenstack-k8s-operators:mainfrom
gmarcian:add_ansibletest_branch
Open

Expose ansibleGitBranch (in test_operator ansibletest config) via cifmw variable#3698
gmarcian wants to merge 2 commits intoopenstack-k8s-operators:mainfrom
gmarcian:add_ansibletest_branch

Conversation

@gmarcian
Copy link

This change adds the ability to set ansibleGitBranch in the test_operator config via the cifmw_test_operator_ansibletest_ansible_git_branch variable.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 19, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sauragar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 19, 2026

Hi @gmarcian. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gmarcian gmarcian changed the title Expose ansibleGitBranch in test_operator ansibletest via cifmw variable Expose ansibleGitBranch (in test_operator ansibletest config) via cifmw variable Feb 19, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 19, 2026

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@michburk
Copy link
Contributor

Hi, thanks for the patch. Can you submit these changes as just one commit and get rid of the merge commit? Our ci bot is complaining about the merge commit.

Additionally, two of our other ci checks failed:
Your commit should have a description, and at the bottom of the commit body include a Signed-off-by line
Include the name of the role you're modifying in brackets or parenthesis at the beginning of your commit title
for example:
[test_operator] Expose ansibleGitBranch via a cifmw variable

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants