Skip to content

Conversation

@klgill
Copy link
Contributor

@klgill klgill commented Dec 12, 2025

@openshift-ci
Copy link

openshift-ci bot commented Dec 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign archana203 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@klgill klgill requested review from bogdando and jistr December 12, 2025 16:02
@jistr
Copy link
Contributor

jistr commented Dec 15, 2025

/lgtm

Copy link
Contributor

@bogdando bogdando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should maintain the test steps to stay connected with the docs. We are going to test that in all test suits we execute, so the docs should be aligned.

@jistr
Copy link
Contributor

jistr commented Dec 15, 2025

I think there doesn't need to be alignment between the documentation and the test suite in all respects. Having extra verification in the test suite is ok. If we want to align the verification between docs and test suite, i think we should come up with a new method that doesn't require the customers to launch additional VMs.

Consider that the CI always does more verification. Among other things it also runs tempest, and we do not recommend running that in customer envs for similar reasons like we're removing the VM steps here -- it is too invasive to be a part of the prescribed production procedures.

@klgill
Copy link
Contributor Author

klgill commented Dec 15, 2025

The following PR supersedes this one, so I'm closing it: #1182

@klgill klgill closed this Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants