-
Notifications
You must be signed in to change notification settings - Fork 67
[18.0-fr2] [dataplane_adoption] Exclude incompatible ceph-common #957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0-fr2] [dataplane_adoption] Exclude incompatible ceph-common #957
Conversation
A recent update to ceph also pulling latest openssl from centos 9-stream which is not compatible with installed rhel 9.2 openssh. So as a workaround excluding ceph-common. Related-Issue: #OSPCIX-843
@@ -106,6 +106,9 @@ edpm_bootstrap_command: | | |||
update-crypto-policies --set FIPS:NO-ENFORCE-EMS | |||
./venv/bin/repo-setup current-podified -b antelope -d centos9 --stream | |||
{%+ if compute_adoption|bool +%} | |||
# Exclude ceph-common-18.2.7 as it's pulling newer openssl not compatible | |||
# with rhel 9.2 openssh | |||
dnf config-manager --setopt centos9-storage.exclude="ceph-common-18.2.7" --save |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's with 'centos9-storage' here - is that right for downstream testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for downstream but it may be needed for upstream periodic. We should probably add a condition around this line to execute it only if the host OS is CentOS (=> in upstream jobs). But not in this backport, it should be done on main
branch too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have edpm_bootstrap_command override in downstream and centos9-storage is not used there at all.
In upstream all jobs has centos9-storage enabled and so condition around this line doesn't make sense.
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/111b43aa77474e52abd2e6e23704fb17 ✔️ noop SUCCESS in 0s |
I wonder if that line can break downstream jobs? I assume those wouldn't have And ideally the comment would also say that this is a CI-specific workaround that deviates from docs. Both of those edits should be done on |
recheck |
We don't need to worry about the command affecting downstream jobs, because the I count Mikolaj's restore of this patch as a positive review, adding mine and merging. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jistr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2def62f
into
openstack-k8s-operators:18.0-fr2
This is an automated cherry-pick of #954
/assign arxcruz