Skip to content

[18.0-fr2] [dataplane_adoption] Exclude incompatible ceph-common #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #954

/assign arxcruz

A recent update to ceph also pulling latest openssl from
centos 9-stream which is not compatible with installed
rhel 9.2 openssh. So as a workaround excluding ceph-common.

Related-Issue: #OSPCIX-843
@@ -106,6 +106,9 @@ edpm_bootstrap_command: |
update-crypto-policies --set FIPS:NO-ENFORCE-EMS
./venv/bin/repo-setup current-podified -b antelope -d centos9 --stream
{%+ if compute_adoption|bool +%}
# Exclude ceph-common-18.2.7 as it's pulling newer openssl not compatible
# with rhel 9.2 openssh
dnf config-manager --setopt centos9-storage.exclude="ceph-common-18.2.7" --save

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with 'centos9-storage' here - is that right for downstream testing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for downstream but it may be needed for upstream periodic. We should probably add a condition around this line to execute it only if the host OS is CentOS (=> in upstream jobs). But not in this backport, it should be done on main branch too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have edpm_bootstrap_command override in downstream and centos9-storage is not used there at all.
In upstream all jobs has centos9-storage enabled and so condition around this line doesn't make sense.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/111b43aa77474e52abd2e6e23704fb17

✔️ noop SUCCESS in 0s
✔️ adoption-standalone-to-crc-ceph SUCCESS in 3h 08m 12s
adoption-standalone-to-crc-no-ceph RETRY_LIMIT in 41m 07s

@jistr
Copy link
Contributor

jistr commented May 28, 2025

I wonder if that line can break downstream jobs? I assume those wouldn't have centos9-storage repo present. We should add a condition "only execute this if the host OS is CentOS"?

And ideally the comment would also say that this is a CI-specific workaround that deviates from docs. Both of those edits should be done on main branch first.

@arxcruz arxcruz closed this May 28, 2025
@ciecierski ciecierski reopened this Jun 3, 2025
@ciecierski
Copy link
Contributor

recheck

@jistr
Copy link
Contributor

jistr commented Jun 4, 2025

We don't need to worry about the command affecting downstream jobs, because the edpm_bootstrap_command variable is overriden there anyway.

I count Mikolaj's restore of this patch as a positive review, adding mine and merging.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Jun 4, 2025
Copy link

openshift-ci bot commented Jun 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jistr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 4, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 2def62f into openstack-k8s-operators:18.0-fr2 Jun 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants