Skip to content

Minor ipv6-nat64 fixes #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Minor ipv6-nat64 fixes #1020

wants to merge 1 commit into from

Conversation

steveb
Copy link
Contributor

@steveb steveb commented Mar 4, 2025

  • sudo where appropriate
  • use full context for chcon calls
  • reduce the default of the size of SNO disk from 150G to 31G which aligns with CRC

@steveb
Minor ipv6-nat64 fixes
6452459 
- sudo where appropriate
- use full context for chcon calls
- reduce the default of the size of SNO disk from 150G to 31G which
  aligns with CRC
@steveb steveb requested a review from hjensas March 4, 2025 02:17
@openshift-ci openshift-ci bot requested review from karelyatin and raukadah March 4, 2025 02:17
@openshift-ci openshift-ci bot added the lgtm label Mar 4, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hjensas, steveb
Once this PR has been reviewed and has the lgtm label, please assign viroel for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bshephar
bshephar reviewed Mar 12, 2025
View reviewed changes
Copy link
Contributor

@bshephar bshephar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly seems fine to me. I just wonder how much space is consumed by all of the local-storage PV's for a fully deployed environment on CRC?

Don't want to have some subset of CI jobs failing because they're filling up the 31GB of storage

devsetup/scripts/ipv6-nat64/sno.sh
VCPUS="${VCPUS:-12}"
OS_VARIANT="${OS_VARIANT:-fedora-coreos-stable}"
DISK_SIZE="${DISK_SIZE:-150}"
DISK_SIZE="${DISK_SIZE:-31}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this possibly going to cause issues for some CI jobs since we use local-storage? Or do we think 31GB should be sufficient for all of our jobs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want to align this with CRC. Jobs will be overriding this value for their requirements where necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hjensas hjensas hjensas approved these changes

@karelyatin karelyatin Awaiting requested review from karelyatin

@raukadah raukadah Awaiting requested review from raukadah

+1 more reviewer

@bshephar bshephar bshephar left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@hjensas hjensas

Labels

lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@steveb @hjensas @bshephar