Skip to content

Switch to continuous logging during update. #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sathlan
Copy link
Contributor

@sathlan sathlan commented Mar 27, 2025

We now have a continuous monitoring running in the background, so we
just need to log the current step of the update and it will be logged.

We also ensure that we don't run any log if it's an install_yaml only
update.

Depends-On: openstack-k8s-operators/ci-framework#2841

Resolves: OSPRH-16018

@openshift-ci openshift-ci bot requested review from fultonj and karelyatin March 27, 2025 12:30
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a49156ce2e574046ae75a403c1b625ea

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 30m 54s
install-yamls-crc-podified-edpm-baremetal RETRY_LIMIT in 21m 35s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 13m 57s

@sathlan
Copy link
Contributor Author

sathlan commented Mar 31, 2025

/retest

@sathlan
Copy link
Contributor Author

sathlan commented Apr 1, 2025

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/af9283b7c78241d1af681fc6cdd9e0c4

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 51m 41s
install-yamls-crc-podified-edpm-baremetal FAILURE in 1h 33m 52s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 09m 52s

@sathlan sathlan force-pushed the continuous-monitoring branch from b4e837a to 32983f6 Compare April 10, 2025 19:31
@sathlan sathlan requested a review from ciecierski April 10, 2025 19:32
@sathlan sathlan force-pushed the continuous-monitoring branch from 32983f6 to a80e82a Compare April 27, 2025 21:53
@sathlan sathlan force-pushed the continuous-monitoring branch from a80e82a to 61f3b39 Compare May 12, 2025 22:34
@@ -91,6 +52,8 @@ if [ "${FAKE_UPDATE}" != "false" ]; then
OPENSTACK_DEPLOYED_VERSION=$(oc get -n $NAMESPACE $OPENSTACK_VERSION_CR --template={{.spec.targetVersion}})
sed -i $OUTFILE -e "s|value: $OPENSTACK_DEPLOYED_VERSION|value: $OPENSTACK_VERSION|"

${UPDATE_ARTIFACT_DIR}/update_event.sh Applying Fake Update CR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is creating update_event.sh file? Is this file created by ci-framework?
I ran this make make openstack_update_run and got error:
update_event.sh': No such file or directory and file is not existing on my env.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in latest version. The script is created by ci-framework, so now I check if the script exist before pushing the event.

We now have a continuous monitoring running in the background, so we
just need to log the current step of the update and it will be logged.

Depends-On: openstack-k8s-operators/ci-framework#2841

Resolves: [OSPRH-15060](https://issues.redhat.com/browse/OSPRH-15060)
@sathlan sathlan force-pushed the continuous-monitoring branch from 61f3b39 to 9bb7c5d Compare May 19, 2025 13:29
Copy link
Contributor

@ciecierski ciecierski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

openshift-ci bot commented May 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ciecierski, sathlan
Once this PR has been reviewed and has the lgtm label, please assign abays for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jistr
Copy link
Contributor

jistr commented May 22, 2025

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants