-
Notifications
You must be signed in to change notification settings - Fork 107
Switch to continuous logging during update. #1036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Switch to continuous logging during update. #1036
Conversation
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a49156ce2e574046ae75a403c1b625ea ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 30m 54s |
/retest |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/af9283b7c78241d1af681fc6cdd9e0c4 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 51m 41s |
b4e837a
to
32983f6
Compare
32983f6
to
a80e82a
Compare
a80e82a
to
61f3b39
Compare
scripts/openstack-update.sh
Outdated
@@ -91,6 +52,8 @@ if [ "${FAKE_UPDATE}" != "false" ]; then | |||
OPENSTACK_DEPLOYED_VERSION=$(oc get -n $NAMESPACE $OPENSTACK_VERSION_CR --template={{.spec.targetVersion}}) | |||
sed -i $OUTFILE -e "s|value: $OPENSTACK_DEPLOYED_VERSION|value: $OPENSTACK_VERSION|" | |||
|
|||
${UPDATE_ARTIFACT_DIR}/update_event.sh Applying Fake Update CR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is creating update_event.sh file? Is this file created by ci-framework?
I ran this make make openstack_update_run
and got error:
update_event.sh': No such file or directory
and file is not existing on my env.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in latest version. The script is created by ci-framework
, so now I check if the script exist before pushing the event.
We now have a continuous monitoring running in the background, so we just need to log the current step of the update and it will be logged. Depends-On: openstack-k8s-operators/ci-framework#2841 Resolves: [OSPRH-15060](https://issues.redhat.com/browse/OSPRH-15060)
61f3b39
to
9bb7c5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ciecierski, sathlan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
We now have a continuous monitoring running in the background, so we
just need to log the current step of the update and it will be logged.
We also ensure that we don't run any log if it's an install_yaml only
update.
Depends-On: openstack-k8s-operators/ci-framework#2841
Resolves: OSPRH-16018