Skip to content

Conversation

eb4x
Copy link

@eb4x eb4x commented Apr 29, 2025

Slightly different approach, just get the latest (v0.14.2) release, patch what needs to be patched and and apply with -k for kustomize. No need to wait for operatorhub.io or the deployment to fail before patching.

The deployment for webhook-server wants to pull
quay.io/metallb/controller:main for the webhook-server. Which seems to be a moving target, and recently was expecting to find an additional CRD for service.BGPStatuses. So we pin the controller to v0.14.5, which is what the other controller images are pinned to in this release.

Slightly different approach, just get the latest (v0.14.2) release,
patch what needs to be patched and and apply with -k for kustomize.
No need to wait for operatorhub.io or the deployment to fail before
patching.

The deployment for webhook-server wants to pull
quay.io/metallb/controller:main for the webhook-server. Which seems
to be a moving target, and recently was expecting to find an
additional CRD for service.BGPStatuses. So we pin the controller to
v0.14.5, which is what the other controller images are pinned to in
this release.
@openshift-ci openshift-ci bot requested review from fmount and viroel April 29, 2025 09:16
Copy link
Contributor

openshift-ci bot commented Apr 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eb4x
Once this PR has been reviewed and has the lgtm label, please assign gibizer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Apr 29, 2025

Hi @eb4x. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant