Complete webhook validation for topology references #484
Conversation
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8708d6b46aa0445fa69cc76e74d74e43 ❌ openstack-k8s-operators-content-provider FAILURE in 10m 11s |
fmount
changed the title
fmount
force-pushed
the
topologyref_webhook
branch
from
5881c59 to
6d6bbf8
Compare
This patch improves the topology webhook validation. In particular: - it optimizes the validation calls; it refines how validation is triggered and reduces code duplication - it leverages the centralized topology validator introduced in infra-operator [1] [1] openstack-k8s-operators/infra-operator#356 Signed-off-by: Francesco Pantano <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit a97f9c7
into
openstack-k8s-operators:main
This patch is a follow up of [1] in the validation
webhookarea. It enhances the validation workflow and it aims to complete the pattern by distributing theValidateTopologylogic across theAPIinstances.It is based on [2] and the key improvements include:
Distributed validation: it provides aValidateTopologyfunction across all API instances, ensuring consistent validation throughout the systemOptimized validation calls: it refines how validation is triggered and reduce code duplication; it still requires a basic struct refactor to fully de-duplicate the existing functions, but it can be done as part of a follow upThis patch leverages the centralized topology validator introduced in
infra-operator[3].Jira: https://issues.redhat.com/browse/OSPRH-14626
[1] openstack-k8s-operators#924
[2] openstack-k8s-operators/nova-operator#936
[3] openstack-k8s-operators/infra-operator#356