Skip to content

[DNM] S2I images except neutron-server check - #684

Open
karelyatin wants to merge 1 commit into
openstack-k8s-operators:mainfrom
karelyatin:s2i_check
Open

[DNM] S2I images except neutron-server check#684
karelyatin wants to merge 1 commit into
openstack-k8s-operators:mainfrom
karelyatin:s2i_check

Conversation

@karelyatin

Copy link
Copy Markdown
Contributor

@openshift-ci
openshift-ci Bot requested review from abays and stuggi August 20, 2026 04:47
@openshift-ci

openshift-ci Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karelyatin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 13e98f9b-5306-478a-ae0d-2b28995c33ad

📥 Commits

Reviewing files that changed from the base of the PR and between 78c171a and 543d4c0.

📒 Files selected for processing (1)
  • zuul.d/jobs.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • New Features

    • Updated test environments to use the latest container images for networking, OVN, and Tempest components.
    • Enabled SNAT rules for nested networks in Tempest configuration.
  • Bug Fixes

    • Excluded two incompatible networking tests from the multinode Tempest job to improve test reliability and reduce false failures.
    • Improved test configuration by separating Tempest image and tag settings for more consistent execution.

Walkthrough

The multinode Tempest Zuul job now uses custom master-latest images, explicit Tempest image variables, a nested-network SNAT override, and two excluded tests.

Changes

Multinode Tempest job

Layer / File(s) Summary
Pin multinode job images
zuul.d/jobs.yaml
The job defines custom master-latest images for Neutron, OVN, and Tempest components. It replaces the previous Tempest container variable with separate image and tag variables.
Adjust Tempest configuration
zuul.d/jobs.yaml
The job enables snat_rules_apply_to_nested_networks and excludes NetworkMultipleGWTest and L3AgentSchedulerTestJSON with explanatory comments.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 543d4

This change updates CI job configuration, and configuration-only edits still trigger the relevant Tempest job. No actionable merge-blocking risk remains after normal checks.

Suggested reviewers: abays, stuggi

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the work-in-progress S2I image check and its neutron-server exclusion.
Description check ✅ Passed The description identifies the dependency for this S2I image check, which relates to the pull request objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/51daa87b610046edba94b596dc7f3628

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 48m 15s
neutron-operator-tempest-multinode FAILURE in 2h 21m 37s

Depends-On: openstack-k8s-operators/ci-framework#4099
Signed-off-by: Yatin Karel <ykarel@redhat.com>
@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/c2b8148fe4974120b54ab921636357cb

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 51m 37s
neutron-operator-tempest-multinode FAILURE in 2h 22m 00s

@openshift-ci

openshift-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant