Skip to content

[ci] Provide a zuul status to github when irrelevant files are changed #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

elfiesmelfie
Copy link
Contributor

Adds the no-op job from feature-verificaton-tests, which will run and provide a passing status from zuul.
This is needed because github expects a status from zuul before it can mark a PR as passing/failing CI.

Copy link
Contributor

openshift-ci bot commented Mar 5, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Mar 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfiesmelfie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -95,3 +95,6 @@
- functional-logging-tests-osp18: *fvt_jobs_config
- functional-graphing-tests-osp18: *fvt_jobs_config
- functional-metric-verification-tests-osp18: *fvt_jobs_config
- feature-verification-tests-noop:
files: &irrelevant_files
- OWNERS*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for Zuul giving some response, but prow needs to be updated to similarly ignore some of these files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, it looks like prow just doesn't do anything on draft PRs

@elfiesmelfie elfiesmelfie marked this pull request as ready for review March 19, 2025 19:25
@openshift-ci openshift-ci bot requested review from jlarriba and mgirgisf March 19, 2025 19:25
Adds the no-op job from feature-verificaton-tests, which will run and
provide a passing status from zuul.
This is needed because github expects a status from zuul before it can
mark a PR as passing/failing CI.
@jlarriba
Copy link
Collaborator

/retest

Get "https://quay.rdoproject.org/v2/": dial tcp 38.129.56.158:443: i/o timeout

@elfiesmelfie
Copy link
Contributor Author

/retest-required

@jlarriba
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 24, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit d064f87 into main Mar 24, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants