-
Notifications
You must be signed in to change notification settings - Fork 40
[ci] Provide a zuul status to github when irrelevant files are changed #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfiesmelfie The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
zuul.d/projects.yaml
Outdated
@@ -95,3 +95,6 @@ | |||
- functional-logging-tests-osp18: *fvt_jobs_config | |||
- functional-graphing-tests-osp18: *fvt_jobs_config | |||
- functional-metric-verification-tests-osp18: *fvt_jobs_config | |||
- feature-verification-tests-noop: | |||
files: &irrelevant_files | |||
- OWNERS* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for Zuul giving some response, but prow needs to be updated to similarly ignore some of these files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, it looks like prow just doesn't do anything on draft PRs
Adds the no-op job from feature-verificaton-tests, which will run and provide a passing status from zuul. This is needed because github expects a status from zuul before it can mark a PR as passing/failing CI.
fd28c34
to
bb88c89
Compare
/retest
|
/retest-required |
/lgtm |
Adds the no-op job from feature-verificaton-tests, which will run and provide a passing status from zuul.
This is needed because github expects a status from zuul before it can mark a PR as passing/failing CI.