fix: custom domain resolution for self-hosted instances#2019
Open
cyphercodes wants to merge 1 commit intoopenstatusHQ:mainfrom
Open
fix: custom domain resolution for self-hosted instances#2019cyphercodes wants to merge 1 commit intoopenstatusHQ:mainfrom
cyphercodes wants to merge 1 commit intoopenstatusHQ:mainfrom
Conversation
Skip stpg.dev domain checks when SELF_HOST=true environment variable is set. This fixes custom domain resolution in self-hosted deployments where the hardcoded stpg.dev checks were causing redirects to fail. Fixes openstatusHQ#1968
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
@cyphercodes is attempting to deploy a commit to the OpenStatus Team on Vercel. A member of the Team first needs to authorize it. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes custom domain resolution in self-hosted OpenStatus deployments.
Problem
When self-hosting via Docker Compose, custom domains configured on a status page do not resolve correctly. The middleware contains hardcoded checks for
stpg.dev(the hosted SaaS platform domain) which breaks custom domain resolution in self-hosted contexts.Solution
Check the
SELF_HOSTenvironment variable and skip thestpg.devdomain checks when running in self-hosted mode (SELF_HOST=true).Changes
isSelfHostedconstant to detect self-hosted mode viaprocess.env.SELF_HOSTstpg.devcheck when self-hostedFixes #1968