Add validation for lifecycle prefix tags conflict#12220
Open
bhavyaKhatri2703 wants to merge 3 commits into
Open
Add validation for lifecycle prefix tags conflict#12220bhavyaKhatri2703 wants to merge 3 commits into
bhavyaKhatri2703 wants to merge 3 commits into
Conversation
RudyTheDev
reviewed
May 30, 2026
| @@ -433,3 +431,15 @@ export const osmUrlKeys = new Set([ | |||
| 'website:menu', | |||
| 'post_office:website', | |||
| ]); | |||
|
|
|||
| export const osmLifecycleConflictPrefixes = new Set([ | |||
Contributor
There was a problem hiding this comment.
What is this list based on? The prefixes documented on https://wiki.openstreetmap.org/wiki/Lifecycle_prefix are slightly different.
Why isn't this just using osmLifecyclePrefixes, why a separate list?
Contributor
|
What about something like Or what about something like This should really have unit tests for common scenarios/examples and edge cases. |
Collaborator
|
The next, planned step for lifecycle tags is #10844 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #12187.
This PR adds validation for lifecycle prefix tags and provides an option to remove one of the tags.
Example:
building:destroyed, building