Fix tag search to also check addTags when searching by key=value#12258
Open
yorty001 wants to merge 2 commits into
Open
Fix tag search to also check addTags when searching by key=value#12258yorty001 wants to merge 2 commits into
yorty001 wants to merge 2 commits into
Conversation
matkoniecz
reviewed
Apr 27, 2026
matkoniecz
left a comment
matkoniecz
left a comment
Contributor
There was a problem hiding this comment.
adding also test to https://github.com/matkoniecz/iD/blob/develop/test/spec/presets/collection.js covering this change would be a good idea
Author
|
Just checking whether there’s anything else needed for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12179
Tag search was not checking addTags when matching key=value queries. This meant searching amenity=school would not find School Grounds, even though amenity=school is defined in its addTags.
Fixed by also checking addTags in the leadingTagKeyValues search logic in collection.js.