Conversation
Member
|
Probably worth doing, but part of why I hesitated switching this out in Rapid was because it switches the decryption from sync to async. It's still probably a good idea, but I didn't want to audit all the places that the code is used. |
Collaborator
Author
|
thanks bryan, yeah it was it bit cumbersome to make it fit into the synchronous code, but thankfully it's only used in those 2 places |
Member
|
@k-yle: would you like to add this to the changelog as well? |
Collaborator
Author
|
sure, done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this was originally suggested on the osm discord, but it turns out that person is working on RapiD, not iD. so this PR backports the idea.
like #11634, this reduces the bundle size by about 0.1MB.
AES-CTR is natively supported by WebCrypto, and support by all browsers since 2020.
So the question is: do we need to support 6-year-old browsers?