Copy crossing island tag to crossing nodes#12421
Open
KTibow wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
That's true but I'd expect it to be rather uncommon and easily manually fixable (remember the add point action is manually triggered). I'd also argue that that specific crossing would be better mapped as a crossing + a foot path + another crossing, especially when the current way's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description, Motivation & Context
When iD detects a road/path crossing and suggests creating a missing crossing node, it already copies known crossing details from the crossing way to the generated
highway=crossingnode. This currently includes the crossing type andcrossing:markings.This extends that behavior to also copy
crossing:islandfrom the crossing way to the generated crossing node.This keeps refuge island information with the crossing node when iD automatically creates or repairs the crossing point, matching the existing behavior for crossing markings.
Testing
npm run lint -- --quietpassed.npm run test:once -- test/spec/validations/crossing_ways.jspassed its assertions:83 passed, including the newcrossing:islandtest.SyntaxError: "undefined" is not valid JSONerrors fromhistory.migrateHistoryDataduringcoreContextsetup on my laptop. This matches the baseline local test issue seen in unrelated existing specs.Disclosure
Generated with GPT-5.5 with human oversight.